net/base/mime_sniffer.cc - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/mime_sniffer.cc

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/mime_sniffer.cc

diff --git a/net/base/mime_sniffer.cc b/net/base/mime_sniffer.cc

index cc83c7c3bda84a4377ed2f0aed31b474c73e0bfd..85c915337f2ad0f99a1708f0651df1604de4341c 100644

--- a/net/base/mime_sniffer.cc

+++ b/net/base/mime_sniffer.cc

@@ -804,8 +804,7 @@ bool ShouldSniffMimeType(const GURL& url, const std::string& mime_type) {

UMASnifferHistogramGet("mime_sniffer.ShouldSniffMimeType2", 3);

}

bool sniffable_scheme = url.is_empty() ||

- url.SchemeIs("http") ||

- url.SchemeIs("https") ||

+ url.SchemeIsHttp() ||

url.SchemeIs("ftp") ||

#if defined(OS_ANDROID)

url.SchemeIs("content") ||