net/base/network_change_notifier.cc - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/network_change_notifier.cc

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/network_change_notifier.cc

diff --git a/net/base/network_change_notifier.cc b/net/base/network_change_notifier.cc

index a6335d03dc2ca16fb1e5ff66eb7c993ec952914d..ec85d12e97170cb3ad1c40539146074a48550521 100644

--- a/net/base/network_change_notifier.cc

+++ b/net/base/network_change_notifier.cc

@@ -248,8 +248,7 @@ class HistogramWatcher

// Record histogram data whenever we receive a packet. Should only be called

// from the network thread.

void NotifyDataReceived(const URLRequest& request, int bytes_read) {

- if (IsLocalhost(request.url().host()) ||

- !(request.url().SchemeIs("http") || request.url().SchemeIs("https"))) {

+ if (IsLocalhost(request.url().host()) || !request.url().SchemeIsHttp()) {

return;

}