content/renderer/savable_resources.cc - Issue 23064011: Consolidate scheme checks into an easy GURL method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/savable_resources.cc

Issue 23064011: Consolidate scheme checks into an easy GURL method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/savable_resources.cc

diff --git a/content/renderer/savable_resources.cc b/content/renderer/savable_resources.cc

index d21da17910a71108760b697d68ba6324f79efe91..92c210c466e455c098d665db9fa42ec53981572f 100644

--- a/content/renderer/savable_resources.cc

+++ b/content/renderer/savable_resources.cc

@@ -89,7 +89,7 @@ void GetSavableResourceLinkForElement(

// Ignore those URLs which are not standard protocols. Because FTP

// protocol does no have cache mechanism, we will skip all

// sub-resources if they use FTP protocol.

- if (!u.SchemeIs("http") && !u.SchemeIs("https") && !u.SchemeIs("file"))

+ if (!u.SchemeIsHttp() && !u.SchemeIs("file"))

return;

// Ignore duplicated resource link.

if (!unique_check->resources_set->insert(u).second)