Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2306293002: Replaced PassRefPtr copies with moves in Source/platform. (Closed)

Created:
4 years, 3 months ago by Bugs Nash
Modified:
4 years, 3 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced PassRefPtr copies with moves in Source/platform. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG=640449 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8 Cr-Commit-Position: refs/heads/master@{#416566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M third_party/WebKit/Source/platform/Length.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODArena.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODFreeListArena.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImagePattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDiffuseLighting.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/SegmentReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/ArchiveResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/EncodedFormData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Bugs Nash
4 years, 3 months ago (2016-09-05 04:26:20 UTC) #5
Yuta Kitamura
LGTM +haraken for platform/ owners review
4 years, 3 months ago (2016-09-05 06:37:47 UTC) #9
haraken
LGTM
4 years, 3 months ago (2016-09-05 07:07:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306293002/1
4 years, 3 months ago (2016-09-05 23:00:12 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 23:03:49 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 23:06:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/009459a350906e2c49d20f4f7ee17c7b29c488e8
Cr-Commit-Position: refs/heads/master@{#416566}

Powered by Google App Engine
This is Rietveld 408576698