third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp - Issue 2306293002: Replaced PassRefPtr copies with moves in Source/platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

Issue 2306293002: Replaced PassRefPtr copies with moves in Source/platform. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEDiffuseLighting.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp b/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

index 5940eb167ebbe3c58fcc68987b0b8ac7a88c7261..33220586290f84513216e184d2033f2c0fa4ab59 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

@@ -31,7 +31,7 @@ namespace blink {

FESpecularLighting::FESpecularLighting(Filter* filter, const Color& lightingColor, float surfaceScale,

float specularConstant, float specularExponent, PassRefPtr<LightSource> lightSource)

- : FELighting(filter, SpecularLighting, lightingColor, surfaceScale, 0, specularConstant, specularExponent, lightSource)

+ : FELighting(filter, SpecularLighting, lightingColor, surfaceScale, 0, specularConstant, specularExponent, std::move(lightSource))

{

}

@@ -39,7 +39,7 @@ FESpecularLighting* FESpecularLighting::create(Filter* filter, const Color& ligh

float surfaceScale, float specularConstant, float specularExponent, PassRefPtr<LightSource> lightSource)

{

return new FESpecularLighting(filter, lightingColor, surfaceScale, specularConstant, specularExponent,

- lightSource);

+ std::move(lightSource));

}

FESpecularLighting::~FESpecularLighting()