third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h - Issue 2306293002: Replaced PassRefPtr copies with moves in Source/platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h

Issue 2306293002: Replaced PassRefPtr copies with moves in Source/platform. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h ('k') | third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h

index 1e41352fe950a20bf32b3c4c5cae42607c2aaa9d..f7ca846d021eb40605de8ad3aaf5286d848e49f8 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h

@@ -18,7 +18,7 @@ class PLATFORM_EXPORT DrawingDisplayItem final : public DisplayItem {

public:

DrawingDisplayItem(const DisplayItemClient& client, Type type, sk_sp<const SkPicture> picture, bool knownToBeOpaque = false)

: DisplayItem(client, type, sizeof(*this))

- , m_picture(picture && picture->approximateOpCount() ? picture : nullptr)

+ , m_picture(picture && picture->approximateOpCount() ? std::move(picture) : nullptr)

, m_knownToBeOpaque(knownToBeOpaque)

{

DCHECK(isDrawingType(type));