Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2306203002: Rename HForeignNew -> HCreate (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename HForeignNew -> HCreate In preparation for adding type information as an argument to the JS constructor. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/6627720227e7e9040819259aedc8d0e9cfccd99e

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments and reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -59 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 5 chunks +26 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_branch_builder.dart View 1 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sra1
4 years, 3 months ago (2016-09-02 21:35:00 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2306203002/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/2306203002/diff/1/pkg/compiler/lib/src/ssa/builder.dart#newcode869 pkg/compiler/lib/src/ssa/builder.dart:869: /// A stack of [DartType]s the have been ...
4 years, 3 months ago (2016-09-02 21:46:22 UTC) #4
sra1
https://codereview.chromium.org/2306203002/diff/1/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/2306203002/diff/1/pkg/compiler/lib/src/ssa/builder.dart#newcode869 pkg/compiler/lib/src/ssa/builder.dart:869: /// A stack of [DartType]s the have been seen ...
4 years, 3 months ago (2016-09-02 21:50:27 UTC) #5
sra1
4 years, 3 months ago (2016-09-02 22:12:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6627720227e7e9040819259aedc8d0e9cfccd99e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698