Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/compiler/lib/src/ssa/codegen_helpers.dart

Issue 2306203002: Rename HForeignNew -> HCreate (Closed)
Patch Set: comments and reformat Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/codegen_helpers.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen_helpers.dart b/pkg/compiler/lib/src/ssa/codegen_helpers.dart
index dca34c5016f91460465e5e1c30a635756294c06f..eda5485a70c8697b6bd64377fd949b59c64bb9d4 100644
--- a/pkg/compiler/lib/src/ssa/codegen_helpers.dart
+++ b/pkg/compiler/lib/src/ssa/codegen_helpers.dart
@@ -670,11 +670,10 @@ class SsaConditionMerger extends HGraphVisitor {
}
bool isSafeToGenerateAtUseSite(HInstruction user, HInstruction input) {
- // HForeignNew evaluates arguments in order and passes them to a
- // constructor.
- if (user is HForeignNew) return true;
- // A [HForeign] instruction uses operators and if we generate
- // [input] at use site, the precedence might be wrong.
+ // HCreate evaluates arguments in order and passes them to a constructor.
+ if (user is HCreate) return true;
+ // A [HForeign] instruction uses operators and if we generate [input] at use
+ // site, the precedence or evaluation order might be wrong.
if (user is HForeign) return false;
// A [HCheck] instruction with control flow uses its input
// multiple times, so we avoid generating it at use site.
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698