Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2306203002: Rename HForeignNew -> HCreate (Closed)
Patch Set: comments and reformat Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index c23f3a6bfcf3f0dd5c3807e5e77fbb86ebc9b705..76eb247d677661aeb78a9a1706bf708a4d6e24c3 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -866,12 +866,12 @@ class SsaBuilder extends ast.Visitor
}
}
- /// A stack of [DartType]s the have been seen during inlining of factory
+ /// A stack of [DartType]s that have been seen during inlining of factory
/// constructors. These types are preserved in [HInvokeStatic]s and
- /// [HForeignNew]s inside the inline code and registered during code
- /// generation for these nodes.
- // TODO(karlklose): consider removing this and keeping the (substituted)
- // types of the type variables in an environment (like the [LocalsHandler]).
+ /// [HCreate]s inside the inline code and registered during code generation
+ /// for these nodes.
+ // TODO(karlklose): consider removing this and keeping the (substituted) types
+ // of the type variables in an environment (like the [LocalsHandler]).
final List<DartType> currentInlinedInstantiations = <DartType>[];
final List<AstInliningState> inliningStack = <AstInliningState>[];
@@ -1498,8 +1498,8 @@ class SsaBuilder extends ast.Visitor
HInstruction newObject;
if (!isNativeUpgradeFactory) {
- newObject = new HForeignNew(
- classElement, ssaType, constructorArguments, instantiatedTypes);
+ newObject = new HCreate(
+ classElement, constructorArguments, ssaType, instantiatedTypes);
if (function != null) {
// TODO(johnniwinther): Provide source information for creation
// through synthetic constructors.
@@ -2431,7 +2431,7 @@ class SsaBuilder extends ast.Visitor
TypeMask type =
new TypeMask.nonNullExact(closureClassElement, compiler.world);
- push(new HForeignNew(closureClassElement, type, capturedVariables)
+ push(new HCreate(closureClassElement, capturedVariables, type)
..sourceInformation = sourceInformationBuilder.buildCreate(node));
Element methodElement = nestedClosureData.closureElement;
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698