Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2369)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

Issue 2305013002: Adding parse UMA and pingback metrics (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc
index fdccecb0a1abded0581fa42d962428d5dc202a1c..b7357d0081ae496fad29b210621634ad9638ae5a 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc
@@ -4,26 +4,27 @@
#include "components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h"
namespace data_reduction_proxy {
DataReductionProxyPageLoadTiming::DataReductionProxyPageLoadTiming(
const base::Time& navigation_start,
const base::Optional<base::TimeDelta>& response_start,
const base::Optional<base::TimeDelta>& load_event_start,
const base::Optional<base::TimeDelta>& first_image_paint,
- const base::Optional<base::TimeDelta>& first_contentful_paint)
+ const base::Optional<base::TimeDelta>& first_contentful_paint,
+ const base::Optional<base::TimeDelta>&
+ parse_blocked_on_script_load_duration,
+ const base::Optional<base::TimeDelta>& parse_stop)
: navigation_start(navigation_start),
response_start(response_start),
load_event_start(load_event_start),
first_image_paint(first_image_paint),
- first_contentful_paint(first_contentful_paint) {}
+ first_contentful_paint(first_contentful_paint),
+ parse_blocked_on_script_load_duration(
+ parse_blocked_on_script_load_duration),
+ parse_stop(parse_stop) {}
DataReductionProxyPageLoadTiming::DataReductionProxyPageLoadTiming(
- const DataReductionProxyPageLoadTiming& other)
- : navigation_start(other.navigation_start),
- response_start(other.response_start),
- load_event_start(other.load_event_start),
- first_image_paint(other.first_image_paint),
- first_contentful_paint(other.first_contentful_paint) {}
+ const DataReductionProxyPageLoadTiming& other) = default;
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698