Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h

Issue 2305013002: Adding parse UMA and pingback metrics (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h
index 0d6981b626c9e2981677de6ba745c22b41cc5430..43aa81be8dc1365d4c7484b37047528cce46cebb 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h
@@ -10,35 +10,42 @@
namespace data_reduction_proxy {
// The timing information that is relevant to the Pageload metrics pingback.
struct DataReductionProxyPageLoadTiming {
DataReductionProxyPageLoadTiming(
const base::Time& navigation_start,
const base::Optional<base::TimeDelta>& response_start,
const base::Optional<base::TimeDelta>& load_event_start,
const base::Optional<base::TimeDelta>& first_image_paint,
- const base::Optional<base::TimeDelta>& first_contentful_paint);
+ const base::Optional<base::TimeDelta>& first_contentful_paint,
+ const base::Optional<base::TimeDelta>&
+ parse_blocked_on_script_load_duration,
+ const base::Optional<base::TimeDelta>& parse_stop);
DataReductionProxyPageLoadTiming(
const DataReductionProxyPageLoadTiming& other);
// Time that the navigation for the associated page was initiated.
const base::Time navigation_start;
- // All TimeDeltas are relative to navigation_start
+ // All TimeDeltas are relative to navigation_start.
// Time that the first byte of the response is received.
const base::Optional<base::TimeDelta> response_start;
// Time immediately before the load event is fired.
const base::Optional<base::TimeDelta> load_event_start;
// Time when the first image is painted.
const base::Optional<base::TimeDelta> first_image_paint;
// Time when the first contentful thing (image, text, etc.) is painted.
const base::Optional<base::TimeDelta> first_contentful_paint;
+ // Time that parsing was blocked by loading script.
+ const base::Optional<base::TimeDelta> parse_blocked_on_script_load_duration;
+ // Time when parsing completed.
+ const base::Optional<base::TimeDelta> parse_stop;
};
} // namespace data_reduction_proxy
#endif // COMPONENTS_DATA_REDUCTION_PROXY_CORE_COMMON_DATA_REDUCTION_PROXY_PAGE_LOAD_TIMING_H

Powered by Google App Engine
This is Rietveld 408576698