Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: components/data_reduction_proxy/proto/pageload_metrics.proto

Issue 2305013002: Adding parse UMA and pingback metrics (Closed)
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/proto/pageload_metrics.proto
diff --git a/components/data_reduction_proxy/proto/pageload_metrics.proto b/components/data_reduction_proxy/proto/pageload_metrics.proto
index e6228437a2d3937d7a5ba3c920c2c3234a5c549c..641789f01dcbbc346421833fba6384268d09e8c8 100644
--- a/components/data_reduction_proxy/proto/pageload_metrics.proto
+++ b/components/data_reduction_proxy/proto/pageload_metrics.proto
@@ -13,40 +13,39 @@ package data_reduction_proxy;
// Request message to record metrics for one or more pageloads.
message RecordPageloadMetricsRequest {
// The pageload metrics to record.
repeated PageloadMetrics pageloads = 1;
// Time metrics were sent.
optional Timestamp metrics_sent_time = 2;
}
// Metrics for a single pageload.
message PageloadMetrics {
+ reserved 3;
+
// The possible effective connection type values.
// See //net/nqe/effective_connection_type.h for the detailed description of
// each of the enum values.
enum EffectiveConnectionType {
EFFECTIVE_CONNECTION_TYPE_UNKNOWN = 0;
EFFECTIVE_CONNECTION_TYPE_OFFLINE = 1;
EFFECTIVE_CONNECTION_TYPE_SLOW_2G = 2;
EFFECTIVE_CONNECTION_TYPE_2G = 3;
EFFECTIVE_CONNECTION_TYPE_3G = 4;
EFFECTIVE_CONNECTION_TYPE_4G = 5;
};
// The session key used to load the page.
optional string session_key = 1;
// The time at which the first request of the pageload was made, according to
// the client's clock.
optional Timestamp first_request_time = 2;
- // The time at which the last request of the pageload was made, according to
- // the client's clock.
- optional Timestamp last_request_time = 3;
// The URL of the main page request.
optional string first_request_url = 4;
// The URL of the last request.
optional string last_request_url = 5;
// Time to first contentful paint.
optional Duration time_to_first_contentful_paint = 6;
// Time to first image paint.
optional Duration time_to_first_image_paint = 7;
// Time to first byte.
@@ -56,11 +55,17 @@ message PageloadMetrics {
// The sum of original-content-length values, over resources that were not
// loaded from browser cache.
optional int32 original_page_size_bytes = 10;
// The sum of (compressed) content-length, over resources that were not loaded
// from browser cache.
optional int32 compressed_page_size_bytes = 11;
// The effective connection type at the start of the navigation.
optional EffectiveConnectionType effective_connection_type = 12;
+
+ // The amount of time the parser was blocked by loading script.
+ optional Duration parse_blocked_on_script_load_duration = 13;
+
+ // Time until parsing finished.
+ optional Duration parse_stop = 14;
}
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698