Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2304453004: [Bindings] Expose V8 callback functions in generated code (Closed)

Created:
4 years, 3 months ago by peria
Modified:
4 years, 3 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose V8 callback functions in generated bindings code. Callback functions in bindings were not exposed with 'static' and we would like to use these functions directly from a special .cpp file as a bypass route. BUG=617892 Committed: https://crrev.com/d6181886958c5f3724f2f5c8b6accd4769f30d0c Cr-Commit-Position: refs/heads/master@{#416492}

Patch Set 1 : Expose call Callback functions in binding scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -583 lines) Patch
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/constants.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 102 chunks +102 lines, -102 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 11 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 307 chunks +319 lines, -319 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 26 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
peria
PTL. I'd like to expose these functions to create a static array of external references.
4 years, 3 months ago (2016-09-05 02:14:17 UTC) #4
haraken
LGTM
4 years, 3 months ago (2016-09-05 02:16:22 UTC) #5
bashi
lgtm
4 years, 3 months ago (2016-09-05 02:20:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2304453004/20001
4 years, 3 months ago (2016-09-05 02:27:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-05 03:45:31 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d6181886958c5f3724f2f5c8b6accd4769f30d0c Cr-Commit-Position: refs/heads/master@{#416492}
4 years, 3 months ago (2016-09-05 03:49:07 UTC) #12
Yuki
4 years, 3 months ago (2016-09-05 05:51:32 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698