third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp - Issue 2304453004: [Bindings] Expose V8 callback functions in generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

Issue 2304453004: [Bindings] Expose V8 callback functions in generated code (Closed)

Patch Set: Expose call Callback functions in binding scripts Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

index 0927058e46de2ad8c6177ce6f98b3afff28ecf3d..83b9b47ec29c0f9e72ccc093671b5c58cde1ab1a 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

@@ -58,7 +58,7 @@ static void attr1AttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info

v8SetReturnValueFast(info, WTF::getPtr(impl->attr1()), impl);

}

-static void attr1AttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

+void attr1AttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

TestInterfaceGarbageCollectedV8Internal::attr1AttributeGetter(info);

}

@@ -76,7 +76,7 @@ static void attr1AttributeSetter(v8::Local<v8::Value> v8Value, const v8::Functio

impl->setAttr1(cppValue);

}

-static void attr1AttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

+void attr1AttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

v8::Local<v8::Value> v8Value = info[0];

TestInterfaceGarbageCollectedV8Internal::attr1AttributeSetter(v8Value, info);