third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp - Issue 2304453004: [Bindings] Expose V8 callback functions in generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

Issue 2304453004: [Bindings] Expose V8 callback functions in generated code (Closed)

Patch Set: Expose call Callback functions in binding scripts Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

index bace43323500d52113a8ed8a43d5cc14fe46ef63..90fbd9e50464c7b73f3ef6d094b738be6d508f8b 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

@@ -55,7 +55,7 @@ static void typeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info)

v8SetReturnValueString(info, impl->fastGetAttribute(SVGNames::typeAttr), info.GetIsolate());

}

-static void typeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

+void typeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

SVGTestInterfaceV8Internal::typeAttributeGetter(info);

}

@@ -71,7 +71,7 @@ static void typeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Function

impl->setAttribute(SVGNames::typeAttr, cppValue);

}

-static void typeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

+void typeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

v8::Local<v8::Value> v8Value = info[0];

V0CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;