ash: Move ShelfWidget ownership to WmShelf and refactor access to it

ash: Move ShelfWidget ownership to WmShelf and refactor access to it

This consolidates access to ShelfWidget in a single location.

* Move ShelfWidget ownership to WmShelf
* Remove RootWindowController::shelf_widget() and access it via WmShelf
cleanup
* Move HandleShowMessageCenterBubble to AcceleratorController because it no
longer depends on the aura-only ash::RootWindowController
* Eliminate WmShelf::SetShelfLayoutManager in favor of an explicit create,
shutdown, destroy cycle for ShelfWidget
* Move StatusAreaWidget creation slightly later, needed for above

There's still some ugliness here around ShelfWidget creation/destruction order
but it's better (or at least more explicit) than it was.

Pure refactor, no functional changes.

BUG=615502
TEST=ash_unittests, unit_tests, manual tests of login with and without a
secondary display.

Committed: https://crrev.com/b551aba636f950844dad415bd73e08cdc815ebd6
Cr-Commit-Position: refs/heads/master@{#415826}

[James Cook, 2016-08-31 22:17:52]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-31 22:18:08]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-31 22:18:09]

msw, please take a look.

https://codereview.chromium.org/2304443002/diff/1/ash/common/shelf/shelf_widg...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2304443002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.cc:340: status_area_widget_ = new
StatusAreaWidget(status_container, wm_shelf_);
I tried to move the creation into WmShelf but there are tricky ordering
dependencies between the StatusAreaWidget constructor,
StatusAreaWidget::CreateTrayViews, and access into WmShelf pieces.

https://codereview.chromium.org/2304443002/diff/1/ash/common/shelf/wm_shelf.h
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2304443002/diff/1/ash/common/shelf/wm_shelf.h...
ash/common/shelf/wm_shelf.h:42: virtual void CreateShelfWidget(WmWindow* root);
Ugly, but at least it makes the steps explicit.

[commit-bot: I haz the power, 2016-08-31 22:18:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-31 22:22:15]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-08-31 23:01:39]

lgtm

https://codereview.chromium.org/2304443002/diff/20001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_widget.cc:339: // TODO(jamescook): Move ownership to
RootWindowController.
nit: resolve contradiction between this and the member TODO comment.

https://codereview.chromium.org/2304443002/diff/20001/ash/mus/bridge/wm_shelf...
File ash/mus/bridge/wm_shelf_mus.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/mus/bridge/wm_shelf...
ash/mus/bridge/wm_shelf_mus.cc:15:
WmShelfMus::WmShelfMus(WmRootWindowController* root_window_controller) {
optional nit: pass in WmWindow* root_window

https://codereview.chromium.org/2304443002/diff/20001/ash/root_window_control...
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/root_window_control...
ash/root_window_controller.cc:482: if (wm_shelf_aura_->shelf_layout_manager())
optional nit: curlies

https://codereview.chromium.org/2304443002/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/shell.cc#newcode418
ash/shell.cc:418: for (WmWindow* root : wm_shell_->GetAllRootWindows()) {
optional nit: no curlies

https://codereview.chromium.org/2304443002/diff/20001/ash/shell.cc#newcode575
ash/shell.cc:575: for (WmWindow* root : wm_shell_->GetAllRootWindows()) {
optional nit: no curlies

[James Cook, 2016-08-31 23:33:45]

https://codereview.chromium.org/2304443002/diff/20001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_widget.cc:339: // TODO(jamescook): Move ownership to
RootWindowController.
On 2016/08/31 23:01:39, msw wrote:
> nit: resolve contradiction between this and the member TODO comment.

Done.

https://codereview.chromium.org/2304443002/diff/20001/ash/mus/bridge/wm_shelf...
File ash/mus/bridge/wm_shelf_mus.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/mus/bridge/wm_shelf...
ash/mus/bridge/wm_shelf_mus.cc:15:
WmShelfMus::WmShelfMus(WmRootWindowController* root_window_controller) {
On 2016/08/31 23:01:39, msw wrote:
> optional nit: pass in WmWindow* root_window

Done.

https://codereview.chromium.org/2304443002/diff/20001/ash/root_window_control...
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/root_window_control...
ash/root_window_controller.cc:482: if (wm_shelf_aura_->shelf_layout_manager())
On 2016/08/31 23:01:39, msw wrote:
> optional nit: curlies

Done.

https://codereview.chromium.org/2304443002/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2304443002/diff/20001/ash/shell.cc#newcode418
ash/shell.cc:418: for (WmWindow* root : wm_shell_->GetAllRootWindows()) {
On 2016/08/31 23:01:39, msw wrote:
> optional nit: no curlies

Done.

https://codereview.chromium.org/2304443002/diff/20001/ash/shell.cc#newcode575
ash/shell.cc:575: for (WmWindow* root : wm_shell_->GetAllRootWindows()) {
On 2016/08/31 23:01:39, msw wrote:
> optional nit: no curlies

Done.

[James Cook, 2016-08-31 23:33:52]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-31 23:33:53]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2304443002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-08-31 23:34:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:00:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 01:04:18]

Description was changed from

==========
ash: Move ShelfWidget ownership to WmShelf and refactor access to it

This consolidates access to ShelfWidget in a single location.

* Move ShelfWidget ownership to WmShelf
* Remove RootWindowController::shelf_widget() and access it via WmShelf
cleanup
* Move HandleShowMessageCenterBubble to AcceleratorController because it no
longer depends on the aura-only ash::RootWindowController
* Eliminate WmShelf::SetShelfLayoutManager in favor of an explicit create,
shutdown, destroy cycle for ShelfWidget
* Move StatusAreaWidget creation slightly later, needed for above

There's still some ugliness here around ShelfWidget creation/destruction order
but it's better (or at least more explicit) than it was.

Pure refactor, no functional changes.

BUG=615502
TEST=ash_unittests, unit_tests, manual tests of login with and without a
secondary display.
==========

to

==========
ash: Move ShelfWidget ownership to WmShelf and refactor access to it

This consolidates access to ShelfWidget in a single location.

* Move ShelfWidget ownership to WmShelf
* Remove RootWindowController::shelf_widget() and access it via WmShelf
cleanup
* Move HandleShowMessageCenterBubble to AcceleratorController because it no
longer depends on the aura-only ash::RootWindowController
* Eliminate WmShelf::SetShelfLayoutManager in favor of an explicit create,
shutdown, destroy cycle for ShelfWidget
* Move StatusAreaWidget creation slightly later, needed for above

There's still some ugliness here around ShelfWidget creation/destruction order
but it's better (or at least more explicit) than it was.

Pure refactor, no functional changes.

BUG=615502
TEST=ash_unittests, unit_tests, manual tests of login with and without a
secondary display.

Committed: https://crrev.com/b551aba636f950844dad415bd73e08cdc815ebd6
Cr-Commit-Position: refs/heads/master@{#415826}
==========

[commit-bot: I haz the power, 2016-09-01 01:04:20]

Patchset 3 (id:??) landed as
https://crrev.com/b551aba636f950844dad415bd73e08cdc815ebd6
Cr-Commit-Position: refs/heads/master@{#415826}