Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: ash/root_window_controller.h

Issue 2304443002: ash: Move ShelfWidget ownership to WmShelf and refactor access to it (Closed)
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/root_window_controller.cc ('k') | ash/root_window_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/root_window_controller.h
diff --git a/ash/root_window_controller.h b/ash/root_window_controller.h
index 7481d308425ecb4c3049b49bd344e50e0b607e36..8a18f48d840d7cee44a4dd6445cb710230d1b2fc 100644
--- a/ash/root_window_controller.h
+++ b/ash/root_window_controller.h
@@ -56,7 +56,6 @@ class DockedWindowLayoutManager;
enum class LoginStatus;
class PanelLayoutManager;
class ShelfLayoutManager;
-class ShelfWidget;
class StackingController;
class StatusAreaWidget;
class SystemModalContainerLayoutManager;
@@ -118,11 +117,6 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
WmShelfAura* wm_shelf_aura() const { return wm_shelf_aura_.get(); }
- // Access the shelf widget associated with this root window controller,
- // NULL if no such shelf exists.
- // DEPRECATED: Prefer GetShelf()->shelf_widget().
- ShelfWidget* shelf_widget() { return shelf_widget_.get(); }
-
// Get touch HUDs associated with this root window controller.
TouchHudDebug* touch_hud_debug() const { return touch_hud_debug_; }
TouchHudProjection* touch_hud_projection() const {
@@ -152,6 +146,9 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
// window controller, NULL if no such shelf exists.
ShelfLayoutManager* GetShelfLayoutManager();
+ // May return null, for example for a secondary monitor at the login screen.
+ StatusAreaWidget* GetStatusAreaWidget();
+
// Returns the system tray on this root window. Note that
// calling this on the root window that doesn't have a shelf will
// lead to a crash.
@@ -275,10 +272,6 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
// to it during construction of the shelf widget and status tray.
std::unique_ptr<WmShelfAura> wm_shelf_aura_;
- // The shelf widget for this root window.
- // TODO(jamescook): Move ownership to WmShelf.
- std::unique_ptr<ShelfWidget> shelf_widget_;
-
// An invisible/empty window used as a event target for
// |MouseCursorEventFilter| before a user logs in.
// (crbug.com/266987)
« no previous file with comments | « ash/mus/root_window_controller.cc ('k') | ash/root_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698