Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: ash/wm/overview/window_selector_unittest.cc

Issue 2304443002: ash: Move ShelfWidget ownership to WmShelf and refactor access to it (Closed)
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/test/status_area_widget_test_helper.cc ('k') | ash/wm/workspace_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/overview/window_selector_unittest.cc
diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc
index 442143cf7446bfe4414445ef52725b7187c15441..02efd83c3b1e33a63d71c59b325c4370b8e360bc 100644
--- a/ash/wm/overview/window_selector_unittest.cc
+++ b/ash/wm/overview/window_selector_unittest.cc
@@ -633,7 +633,7 @@ TEST_P(WindowSelectorTest, BasicWithDocked) {
EXPECT_FALSE(WindowsOverlapping(window1.get(), window2.get()));
gfx::Rect container_bounds = docked1->parent()->bounds();
- ShelfWidget* shelf = Shell::GetPrimaryRootWindowController()->shelf_widget();
+ ShelfWidget* shelf = GetPrimaryShelf()->shelf_widget();
DockedWindowLayoutManager* manager =
DockedWindowLayoutManager::Get(WmWindowAura::Get(docked1.get()));
@@ -1174,7 +1174,7 @@ TEST_P(WindowSelectorTest, OverviewUndimsShelf) {
std::unique_ptr<aura::Window> window1(CreateWindow(bounds));
wm::WindowState* window_state = wm::GetWindowState(window1.get());
window_state->Maximize();
- ShelfWidget* shelf = Shell::GetPrimaryRootWindowController()->shelf_widget();
+ ShelfWidget* shelf = GetPrimaryShelf()->shelf_widget();
EXPECT_TRUE(shelf->GetDimsShelf());
ToggleOverview();
EXPECT_FALSE(shelf->GetDimsShelf());
« no previous file with comments | « ash/test/status_area_widget_test_helper.cc ('k') | ash/wm/workspace_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698