Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2304253002: Delay WebUSB initialization until after browser startup. (Closed)

Created:
4 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Delay WebUSB initialization until after browser startup. Initializing the WebUSB device detector module causes the USB service to be initialized and enumerate all USB device connected to the system. This can cause unnecessary delay during browser startup. The purpose of this module is to detect devices connected after Chrome starts to display a notification so it doesn't matter if it is initialized after first page load. An UMA histogram for the time spent initializing the detector is also added to aid further investigation of this issue. BUG=642107 Review-Url: https://codereview.chromium.org/2295023002 Cr-Commit-Position: refs/heads/master@{#415971} (cherry picked from commit 478a62181383d2cc7fa545ee6a7a91ab34fec477) Committed: https://chromium.googlesource.com/chromium/src/+/165965c08079b64a645819ffddc221915891409f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/usb/web_usb_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/web_usb_detector.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/usb/web_usb_detector_unittest.cc View 9 chunks +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
4 years, 3 months ago (2016-09-02 18:28:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
165965c08079b64a645819ffddc221915891409f.

Powered by Google App Engine
This is Rietveld 408576698