Delay WebUSB initialization until after browser startup.

chrome/browser/usb/web_usb_detector_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/usb/web_usb_detector.h"
@@ skipping 42 matching lines @@
 };
 
 TEST_F(WebUsbDetectorTest, UsbDeviceAddedAndRemoved) {
   base::string16 product_name = base::UTF8ToUTF16(kProductName_1);
   GURL landing_page(kLandingPage_1);
   scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
       0, 1, "Google", kProductName_1, "002", landing_page));
   std::string guid = device->guid();
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->AddDevice(device);
   message_center::Notification* notification =
       message_center_->FindVisibleNotificationById(guid);
   ASSERT_TRUE(notification != nullptr);
   base::string16 expected_title =
       base::ASCIIToUTF16("Google Product A detected");
   EXPECT_EQ(expected_title, notification->title());
   base::string16 expected_message =
       base::ASCIIToUTF16("Go to www.google.com/A to connect.");
   EXPECT_EQ(expected_message, notification->message());
   EXPECT_TRUE(notification->delegate() != nullptr);
 
   device_client_.usb_service()->RemoveDevice(device);
   // Device is removed, so notification should be removed from the
   // message_center too.
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
 }
 
 TEST_F(WebUsbDetectorTest, UsbDeviceWithoutProductNameAddedAndRemoved) {
   std::string product_name = "";
   GURL landing_page(kLandingPage_1);
   scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
       0, 1, "Google", product_name, "002", landing_page));
   std::string guid = device->guid();
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->AddDevice(device);
   // For device without product name, no notification is generated.
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
 
   device_client_.usb_service()->RemoveDevice(device);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
 }
 
 TEST_F(WebUsbDetectorTest, UsbDeviceWithoutLandingPageAddedAndRemoved) {
   GURL landing_page("");
   scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
       0, 1, "Google", kProductName_1, "002", landing_page));
   std::string guid = device->guid();
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->AddDevice(device);
   // For device without landing page, no notification is generated.
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
 
   device_client_.usb_service()->RemoveDevice(device);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
 }
 
 TEST_F(WebUsbDetectorTest, UsbDeviceWasThereBeforeAndThenRemoved) {
   GURL landing_page(kLandingPage_1);
   scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
       0, 1, "Google", kProductName_1, "002", landing_page));
   std::string guid = device->guid();
 
   // USB device was added before web_usb_detector was created.
   device_client_.usb_service()->AddDevice(device);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->RemoveDevice(device);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
 }
 
 TEST_F(
     WebUsbDetectorTest,
     ThreeUsbDevicesWereThereBeforeAndThenRemovedBeforeWebUsbDetectorWasCreated) {
   base::string16 product_name_1 = base::UTF8ToUTF16(kProductName_1);
   GURL landing_page_1(kLandingPage_1);
@@ skipping 23 matching lines @@
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
 
   device_client_.usb_service()->RemoveDevice(device_1);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
   device_client_.usb_service()->RemoveDevice(device_2);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_2));
   device_client_.usb_service()->RemoveDevice(device_3);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 }
 
 TEST_F(
     WebUsbDetectorTest,
     ThreeUsbDevicesWereThereBeforeAndThenRemovedAfterWebUsbDetectorWasCreated) {
   base::string16 product_name_1 = base::UTF8ToUTF16(kProductName_1);
   GURL landing_page_1(kLandingPage_1);
   scoped_refptr<device::MockUsbDevice> device_1(new device::MockUsbDevice(
       0, 1, "Google", kProductName_1, "002", landing_page_1));
   std::string guid_1 = device_1->guid();
@@ skipping 12 matching lines @@
 
   // Three usb devices were added before web_usb_detector was created.
   device_client_.usb_service()->AddDevice(device_1);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
   device_client_.usb_service()->AddDevice(device_2);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_2));
   device_client_.usb_service()->AddDevice(device_3);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->RemoveDevice(device_1);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
   device_client_.usb_service()->RemoveDevice(device_2);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_2));
   device_client_.usb_service()->RemoveDevice(device_3);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
 }
 
 TEST_F(WebUsbDetectorTest,
@@ skipping 16 matching lines @@
       6, 7, "Google", kProductName_3, "008", landing_page_3));
   std::string guid_3 = device_3->guid();
 
   // Two usb devices were added before web_usb_detector was created.
   device_client_.usb_service()->AddDevice(device_1);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
   device_client_.usb_service()->AddDevice(device_3);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->RemoveDevice(device_1);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
 
   device_client_.usb_service()->AddDevice(device_2);
   message_center::Notification* notification =
       message_center_->FindVisibleNotificationById(guid_2);
   ASSERT_TRUE(notification != nullptr);
   base::string16 expected_title =
       base::ASCIIToUTF16("Google Product B detected");
@@ skipping 23 matching lines @@
       3, 4, "Google", kProductName_2, "005", landing_page_2));
   std::string guid_2 = device_2->guid();
 
   base::string16 product_name_3 = base::UTF8ToUTF16(kProductName_3);
   GURL landing_page_3(kLandingPage_3);
   scoped_refptr<device::MockUsbDevice> device_3(new device::MockUsbDevice(
       6, 7, "Google", kProductName_3, "008", landing_page_3));
   std::string guid_3 = device_3->guid();
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->AddDevice(device_1);
   message_center::Notification* notification_1 =
       message_center_->FindVisibleNotificationById(guid_1);
   ASSERT_TRUE(notification_1 != nullptr);
   base::string16 expected_title_1 =
       base::ASCIIToUTF16("Google Product A detected");
   EXPECT_EQ(expected_title_1, notification_1->title());
   base::string16 expected_message_1 =
       base::ASCIIToUTF16("Go to www.google.com/A to connect.");
@@ skipping 47 matching lines @@
       3, 4, "Google", kProductName_2, "005", landing_page_2));
   std::string guid_2 = device_2->guid();
 
   base::string16 product_name_3 = base::UTF8ToUTF16(kProductName_3);
   GURL landing_page_3(kLandingPage_3);
   scoped_refptr<device::MockUsbDevice> device_3(new device::MockUsbDevice(
       6, 7, "Google", kProductName_3, "008", landing_page_3));
   std::string guid_3 = device_3->guid();
 
   WebUsbDetector web_usb_detector;
+  web_usb_detector.Initialize();
 
   device_client_.usb_service()->AddDevice(device_1);
   message_center::Notification* notification_1 =
       message_center_->FindVisibleNotificationById(guid_1);
   ASSERT_TRUE(notification_1 != nullptr);
   base::string16 expected_title_1 =
       base::ASCIIToUTF16("Google Product A detected");
   EXPECT_EQ(expected_title_1, notification_1->title());
   base::string16 expected_message_1 =
       base::ASCIIToUTF16("Go to www.google.com/A to connect.");
@@ skipping 26 matching lines @@
       base::ASCIIToUTF16("Go to www.google.com/C to connect.");
   EXPECT_EQ(expected_message_3, notification_3->message());
   EXPECT_TRUE(notification_3->delegate() != nullptr);
 
   device_client_.usb_service()->RemoveDevice(device_1);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
 
   device_client_.usb_service()->RemoveDevice(device_3);
   EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
 }