Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2295023002: Delay WebUSB initialization until after browser startup. (Closed)

Created:
4 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delay WebUSB initialization until after browser startup. Initializing the WebUSB device detector module causes the USB service to be initialized and enumerate all USB device connected to the system. This can cause unnecessary delay during browser startup. The purpose of this module is to detect devices connected after Chrome starts to display a notification so it doesn't matter if it is initialized after first page load. An UMA histogram for the time spent initializing the detector is also added to aid further investigation of this issue. BUG=642107 Committed: https://crrev.com/478a62181383d2cc7fa545ee6a7a91ab34fec477 Cr-Commit-Position: refs/heads/master@{#415971}

Patch Set 1 #

Patch Set 2 : Add UMA for WebUSB detector initialization time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/usb/web_usb_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/web_usb_detector.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/usb/web_usb_detector_unittest.cc View 9 chunks +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 3 months ago (2016-08-31 00:45:49 UTC) #3
jochen (gone - plz use gerrit)
the code changes look good, however, you'll need a separate reviewer for the histogram - ...
4 years, 3 months ago (2016-08-31 14:33:33 UTC) #4
Reilly Grant (use Gerrit)
holte@ please review histograms.xml.
4 years, 3 months ago (2016-08-31 17:09:07 UTC) #6
Reilly Grant (use Gerrit)
On 2016/08/31 at 14:33:33, jochen wrote: > the code changes look good, however, you'll need ...
4 years, 3 months ago (2016-08-31 17:10:02 UTC) #7
Steven Holte
histograms lgtm
4 years, 3 months ago (2016-08-31 21:52:38 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-01 12:14:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295023002/20001
4 years, 3 months ago (2016-09-01 15:38:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 16:43:39 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 16:45:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/478a62181383d2cc7fa545ee6a7a91ab34fec477
Cr-Commit-Position: refs/heads/master@{#415971}

Powered by Google App Engine
This is Rietveld 408576698