Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2303743002: Enable the screenspace AA tessellating path renderer. (Closed)

Created:
4 years, 3 months ago by Stephen White
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable the screenspace AA tessellating path renderer. This will enable the new path renderer in Skia. It is still disabled in Chrome, to protect layout test results. Note: this will cause minor pixel diffs in a number of GMs' GPU results, including drawregionmodes, dstreadshuffle, smallarc, path-reverse, bug339297, parsedpaths, zero_control_stroke, strokedlines, smallpaths, circular_arcs_stroke_round, concavepaths, circular_arcs_stroke_square, clipcubic, arcto, persp_shaders_aa, complexclip3_complex, circular_arcs_stroke_and_fill_butt, complexclip_aa, complexclip_aa_layer, complexclip_aa_invert, complexclip3_simple, complexclip_aa_layer_invert, shadertext, shadertext2, convex-lineonly-paths-stroke-and-fill, poly2poly, glyph_pos_h_b, glyph_pos_h_f, glyph_pos_n_f, and glyph_pos_n_s. Note: it also "fixes" crbug_640176, or more accurately, hides the failure, since the default path renderer likely still has the bug. BUG=642376 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303743002 Committed: https://skia.googlesource.com/skia/+/7370e0d7bd3ac00301e516191683b37fc34b7b49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Stephen White
Brian: PTAL. Thanks!
4 years, 3 months ago (2016-09-01 14:07:40 UTC) #4
bsalomon
lgtm
4 years, 3 months ago (2016-09-01 14:14:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303743002/1
4 years, 3 months ago (2016-09-01 15:22:07 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 15:23:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7370e0d7bd3ac00301e516191683b37fc34b7b49

Powered by Google App Engine
This is Rietveld 408576698