Telemetry: Skip page if a page action is not supported by the browser.

Telemetry: Skip page if a page action is not supported by the browser.

If a page requires touch scrolling, we currently report a failure if the browser
doesn't support touch. This means that no average numbers will be reported on the
dashboard.
Instead of failing, we could skip the page and show a warning message to make the
user aware of that.

BUG=355661
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263014

[Dominik Grewe, 2014-04-09 11:37:23]

PTAL, thanks.

[tonyg, 2014-04-10 01:34:05]

https://codereview.chromium.org/230373005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/230373005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:500: page.url, e)
I think we should call results.AddSkip(page, 'Unsupported page action...')
instead.

[Dominik Grewe, 2014-04-10 13:18:33]

On 2014/04/10 01:34:05, tonyg wrote:
>
https://codereview.chromium.org/230373005/diff/1/tools/telemetry/telemetry/pa...
> File tools/telemetry/telemetry/page/page_runner.py (right):
> 
>
https://codereview.chromium.org/230373005/diff/1/tools/telemetry/telemetry/pa...
> tools/telemetry/telemetry/page/page_runner.py:500: page.url, e)
> I think we should call results.AddSkip(page, 'Unsupported page action...')
> instead.

Oh, didn't realize we had that, sorry.
Shame that the 'reason' just seems to get dropped though. Should we print a
warning in addition to calling AddSkip?

[tonyg, 2014-04-10 14:01:27]

On 2014/04/10 13:18:33, Dominik Grewe wrote:
> On 2014/04/10 01:34:05, tonyg wrote:
> >
>
https://codereview.chromium.org/230373005/diff/1/tools/telemetry/telemetry/pa...
> > File tools/telemetry/telemetry/page/page_runner.py (right):
> > 
> >
>
https://codereview.chromium.org/230373005/diff/1/tools/telemetry/telemetry/pa...
> > tools/telemetry/telemetry/page/page_runner.py:500: page.url, e)
> > I think we should call results.AddSkip(page, 'Unsupported page action...')
> > instead.
> 
> Oh, didn't realize we had that, sorry.
> Shame that the 'reason' just seems to get dropped though. Should we print a
> warning in addition to calling AddSkip?

Let's make AddSkip itself print the warning.

[tonyg, 2014-04-10 14:01:41]

lgtm in advance of last comment

[Dominik Grewe, 2014-04-10 14:32:06]

On 2014/04/10 14:01:41, tonyg wrote:
> lgtm in advance of last comment

Thanks.

[Dominik Grewe, 2014-04-10 14:32:09]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-04-10 14:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/230373005/40001

[commit-bot: I haz the power, 2014-04-10 16:57:09]

Change committed as 263014

[nduca, 2014-04-10 17:23:51]

This is really nice, thank you