tools/telemetry/telemetry/page/page_test_results.py - Issue 230373005: Telemetry: Skip page if a page action is not supported by the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test_results.py

Issue 230373005: Telemetry: Skip page if a page action is not supported by the browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: print warning on addSkip Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_test_results.py

diff --git a/tools/telemetry/telemetry/page/page_test_results.py b/tools/telemetry/telemetry/page/page_test_results.py

index 2910b1e1cbbb20cdd50dfc7147dd0dc514eea5a9..e909e7992b83243d6935b9ea952abf29596970e7 100644

--- a/tools/telemetry/telemetry/page/page_test_results.py

+++ b/tools/telemetry/telemetry/page/page_test_results.py

@@ -42,6 +42,7 @@ class PageTestResults(unittest.TestResult):

self.successes.append(test)

def addSkip(self, test, reason): # Python 2.7 has this in unittest.TestResult

+ logging.warning('%s\n%s\nSkipping page.', test, reason)

self.skipped.append((test, reason))

def StartTest(self, page):

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »