tools/telemetry/telemetry/page/page_runner.py - Issue 230373005: Telemetry: Skip page if a page action is not supported by the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 230373005: Telemetry: Skip page if a page action is not supported by the browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: print warning on addSkip Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index dd54b95fa0c4f865a25b64367a1d725971f7f162..f9d8f27457018d1fd5ed33690bcc3ca2bdc9650a 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -495,6 +495,8 @@ def _RunPage(test, page, state, expectation, results, finder_options):

ProcessError()

# Run() catches these exceptions to relaunch the tab/browser, so re-raise.

raise

+ except page_action.PageActionNotSupported as e:

+ results.AddSkip(page, 'Unsupported page action: %s' % e)

except Exception:

logging.warning('While running %s', page.url)

exception_formatter.PrintFormattedException(*sys.exc_info())

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_test_results.py » ('j') | no next file with comments »