components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2303713002: Implement ClearHistory for all ntp_snippets providers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2303713002: Implement ClearHistory for all ntp_snippets providers (Closed)

Patch Set: Marc's nits. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index f335ec1e6081e6bbf339930f7572e7507e09ed75..6084f12f197de09d17eca77717522e336254984f 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -90,8 +90,7 @@ void PhysicalWebPageSuggestionsProvider::ClearHistory(

base::Time begin,

base::Time end,

const base::Callback<bool(const GURL& url)>& filter) {

- // TODO(vitaliii): Implement when dismissed suggestions are supported. See

- // crbug.com/641321.

+ ClearDismissedSuggestionsForDebugging(provided_category_);

}

void PhysicalWebPageSuggestionsProvider::ClearCachedSuggestions(

« no previous file with comments | « components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc ('k') | no next file » | no next file with comments »