components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc - Issue 2303713002: Implement ClearHistory for all ntp_snippets providers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

Issue 2303713002: Implement ClearHistory for all ntp_snippets providers (Closed)

Patch Set: Marc's nits. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service_unittest.cc ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

index dd2ed1052b50d5aaea72cb5a11424bda1c85846f..3c1b0e3e58017d788e065c94326f0ccf79613398 100644

--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

@@ -154,7 +154,9 @@ void OfflinePageSuggestionsProvider::ClearHistory(

base::Time begin,

base::Time end,

const base::Callback<bool(const GURL& url)>& filter) {

- // TODO(vitaliii): Implement. See crbug.com/641321.

+ ClearDismissedSuggestionsForDebugging(recent_tabs_category_);

+ ClearDismissedSuggestionsForDebugging(downloads_category_);

+ FetchOfflinePages();

}

void OfflinePageSuggestionsProvider::ClearCachedSuggestions(Category category) {