Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2303713002: Implement ClearHistory for all ntp_snippets providers (Closed)
Patch Set: Marc's nits. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestio ns_provider.h" 5 #include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestio ns_provider.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 const std::string& suggestion_id, const ImageFetchedCallback& callback) { 83 const std::string& suggestion_id, const ImageFetchedCallback& callback) {
84 // TODO(vitaliii): Implement. 84 // TODO(vitaliii): Implement.
85 base::ThreadTaskRunnerHandle::Get()->PostTask( 85 base::ThreadTaskRunnerHandle::Get()->PostTask(
86 FROM_HERE, base::Bind(callback, gfx::Image())); 86 FROM_HERE, base::Bind(callback, gfx::Image()));
87 } 87 }
88 88
89 void PhysicalWebPageSuggestionsProvider::ClearHistory( 89 void PhysicalWebPageSuggestionsProvider::ClearHistory(
90 base::Time begin, 90 base::Time begin,
91 base::Time end, 91 base::Time end,
92 const base::Callback<bool(const GURL& url)>& filter) { 92 const base::Callback<bool(const GURL& url)>& filter) {
93 // TODO(vitaliii): Implement when dismissed suggestions are supported. See 93 ClearDismissedSuggestionsForDebugging(provided_category_);
94 // crbug.com/641321.
95 } 94 }
96 95
97 void PhysicalWebPageSuggestionsProvider::ClearCachedSuggestions( 96 void PhysicalWebPageSuggestionsProvider::ClearCachedSuggestions(
98 Category category) { 97 Category category) {
99 // Ignored 98 // Ignored
100 } 99 }
101 100
102 void PhysicalWebPageSuggestionsProvider::GetDismissedSuggestionsForDebugging( 101 void PhysicalWebPageSuggestionsProvider::GetDismissedSuggestionsForDebugging(
103 Category category, 102 Category category,
104 const DismissedSuggestionsCallback& callback) { 103 const DismissedSuggestionsCallback& callback) {
(...skipping 11 matching lines...) Expand all
116 115
117 // Updates the |category_status_| and notifies the |observer_|, if necessary. 116 // Updates the |category_status_| and notifies the |observer_|, if necessary.
118 void PhysicalWebPageSuggestionsProvider::NotifyStatusChanged( 117 void PhysicalWebPageSuggestionsProvider::NotifyStatusChanged(
119 CategoryStatus new_status) { 118 CategoryStatus new_status) {
120 if (category_status_ == new_status) return; 119 if (category_status_ == new_status) return;
121 category_status_ = new_status; 120 category_status_ = new_status;
122 observer()->OnCategoryStatusChanged(this, provided_category_, new_status); 121 observer()->OnCategoryStatusChanged(this, provided_category_, new_status);
123 } 122 }
124 123
125 } // namespace ntp_snippets 124 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698