Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2303663004: Pass null to attributeChangedCallback when there's no namespace URI (Closed)

Created:
4 years, 3 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 3 months ago
Reviewers:
tkent, haraken, hayato
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass null to attributeChangedCallback when there's no namespace URI The DOM spec says attribute namespaces may be null, or non-empty [1]. We should accurately transmit those nulls to the attributeChangedCallback [2]. We were converting null to empty string. This also adds a test that non-null namespaces are transmitted, too. [1] https://dom.spec.whatwg.org/#concept-attribute-namespace [2] https://dom.spec.whatwg.org/#concept-element-attributes-change , etc. BUG=643046 Committed: https://crrev.com/d39405eee528d5cec4edcb6dd9abfdc83b897fe8 Cr-Commit-Position: refs/heads/master@{#416458}

Patch Set 1 #

Patch Set 2 : Update test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/callback.html View 9 chunks +29 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element.html View 1 6 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 3 months ago (2016-09-02 04:18:25 UTC) #4
hayato
LGTM. Could you check custom-elements/spec/upgrade-element.html? It looks failing.
4 years, 3 months ago (2016-09-02 06:11:10 UTC) #8
tkent
lgtm
4 years, 3 months ago (2016-09-02 06:42:57 UTC) #11
dominicc (has gone to gerrit)
4 years, 3 months ago (2016-09-02 06:44:42 UTC) #12
haraken
bindings/ LGTM
4 years, 3 months ago (2016-09-02 08:41:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303663004/20001
4 years, 3 months ago (2016-09-03 22:15:58 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-04 00:13:09 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 00:16:10 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d39405eee528d5cec4edcb6dd9abfdc83b897fe8
Cr-Commit-Position: refs/heads/master@{#416458}

Powered by Google App Engine
This is Rietveld 408576698