third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp - Issue 2303663004: Pass null to attributeChangedCallback when there's no namespace URI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2303663004: Pass null to attributeChangedCallback when there's no namespace URI (Closed)

Patch Set: Update test. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

index 389e73138753f140bd984e14be476c85357406f1..4658373cd9388238084cb47dca462657d15664cb 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

@@ -378,7 +378,7 @@ void ScriptCustomElementDefinition::runAttributeChangedCallback(

v8String(isolate, name.localName()),

v8StringOrNull(isolate, oldValue),

v8StringOrNull(isolate, newValue),

- v8String(isolate, name.namespaceURI()),

+ v8StringOrNull(isolate, name.namespaceURI()),

};

runCallback(m_attributeChangedCallback.newLocal(isolate), element,

argc, argv);

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element.html ('k') | no next file » | no next file with comments »