Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2303663004: Pass null to attributeChangedCallback when there's no namespace URI (Closed)
Patch Set: Update test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ScriptCustomElementDefinition.h" 5 #include "bindings/core/v8/ScriptCustomElementDefinition.h"
6 6
7 #include "bindings/core/v8/ScriptState.h" 7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/V8Binding.h" 8 #include "bindings/core/v8/V8Binding.h"
9 #include "bindings/core/v8/V8BindingMacros.h" 9 #include "bindings/core/v8/V8BindingMacros.h"
10 #include "bindings/core/v8/V8CustomElementRegistry.h" 10 #include "bindings/core/v8/V8CustomElementRegistry.h"
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 { 371 {
372 if (!m_scriptState->contextIsValid()) 372 if (!m_scriptState->contextIsValid())
373 return; 373 return;
374 ScriptState::Scope scope(m_scriptState.get()); 374 ScriptState::Scope scope(m_scriptState.get());
375 v8::Isolate* isolate = m_scriptState->isolate(); 375 v8::Isolate* isolate = m_scriptState->isolate();
376 const int argc = 4; 376 const int argc = 4;
377 v8::Local<v8::Value> argv[argc] = { 377 v8::Local<v8::Value> argv[argc] = {
378 v8String(isolate, name.localName()), 378 v8String(isolate, name.localName()),
379 v8StringOrNull(isolate, oldValue), 379 v8StringOrNull(isolate, oldValue),
380 v8StringOrNull(isolate, newValue), 380 v8StringOrNull(isolate, newValue),
381 v8String(isolate, name.namespaceURI()), 381 v8StringOrNull(isolate, name.namespaceURI()),
382 }; 382 };
383 runCallback(m_attributeChangedCallback.newLocal(isolate), element, 383 runCallback(m_attributeChangedCallback.newLocal(isolate), element,
384 argc, argv); 384 argc, argv);
385 } 385 }
386 386
387 } // namespace blink 387 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698