Issue 2303073002: Avoid to return null in anyRef if object is not known

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2303073002: Avoid to return null in anyRef if object is not known (Closed)

Created:
4 years, 3 months ago by cbernaschina

Modified:
4 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Avoid to return null in anyRef if object is not known Fixes=https://github.com/dart-lang/sdk/issues/27222 TBR=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5703296fe61b6e07c885033858071604dfe2dc89

Patch Set 1 #

Total comments: 1

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	runtime/observatory/lib/src/elements/helpers/any_ref.dart	View		2 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

cbernaschina

Committed patchset #1 (id:1) manually as 5703296fe61b6e07c885033858071604dfe2dc89 (presubmit successful).

4 years, 3 months ago (2016-09-01 21:47:43 UTC) #3

rmacnak

4 years, 3 months ago (2016-09-01 22:24:52 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2303073002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/helpers/any_ref.dart (right):

https://codereview.chromium.org/2303073002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/helpers/any_ref.dart:75: throw new
Exception('Unknown runtimeType (${ref.runtimeType})');
Unknown ref

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages