Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: runtime/observatory/lib/src/elements/helpers/any_ref.dart

Issue 2303073002: Avoid to return null in anyRef if object is not known (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'package:observatory/models.dart' as M; 6 import 'package:observatory/models.dart' as M;
7 import 'package:observatory/src/elements/class_ref.dart'; 7 import 'package:observatory/src/elements/class_ref.dart';
8 import 'package:observatory/src/elements/code_ref.dart'; 8 import 'package:observatory/src/elements/code_ref.dart';
9 import 'package:observatory/src/elements/context_ref.dart'; 9 import 'package:observatory/src/elements/context_ref.dart';
10 import 'package:observatory/src/elements/error_ref.dart'; 10 import 'package:observatory/src/elements/error_ref.dart';
11 import 'package:observatory/src/elements/field_ref.dart'; 11 import 'package:observatory/src/elements/field_ref.dart';
12 import 'package:observatory/src/elements/function_ref.dart'; 12 import 'package:observatory/src/elements/function_ref.dart';
13 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; 13 import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
14 import 'package:observatory/src/elements/helpers/uris.dart';
14 import 'package:observatory/src/elements/icdata_ref.dart'; 15 import 'package:observatory/src/elements/icdata_ref.dart';
15 import 'package:observatory/src/elements/instance_ref.dart'; 16 import 'package:observatory/src/elements/instance_ref.dart';
16 import 'package:observatory/src/elements/megamorphiccache_ref.dart'; 17 import 'package:observatory/src/elements/megamorphiccache_ref.dart';
17 import 'package:observatory/src/elements/library_ref.dart'; 18 import 'package:observatory/src/elements/library_ref.dart';
18 import 'package:observatory/src/elements/local_var_descriptors_ref.dart'; 19 import 'package:observatory/src/elements/local_var_descriptors_ref.dart';
19 import 'package:observatory/src/elements/objectpool_ref.dart'; 20 import 'package:observatory/src/elements/objectpool_ref.dart';
20 import 'package:observatory/src/elements/pc_descriptors_ref.dart'; 21 import 'package:observatory/src/elements/pc_descriptors_ref.dart';
21 import 'package:observatory/src/elements/script_ref.dart'; 22 import 'package:observatory/src/elements/script_ref.dart';
22 import 'package:observatory/src/elements/sentinel_value.dart'; 23 import 'package:observatory/src/elements/sentinel_value.dart';
23 import 'package:observatory/src/elements/type_arguments_ref.dart'; 24 import 'package:observatory/src/elements/type_arguments_ref.dart';
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } else if (ref is M.Sentinel) { 60 } else if (ref is M.Sentinel) {
60 return new SentinelValueElement(ref, queue: queue); 61 return new SentinelValueElement(ref, queue: queue);
61 } else if (ref is M.ScriptRef) { 62 } else if (ref is M.ScriptRef) {
62 return new ScriptRefElement(isolate, ref, queue: queue); 63 return new ScriptRefElement(isolate, ref, queue: queue);
63 } else if (ref is M.TypeArgumentsRef) { 64 } else if (ref is M.TypeArgumentsRef) {
64 return new TypeArgumentsRefElement(isolate, ref, queue: queue); 65 return new TypeArgumentsRefElement(isolate, ref, queue: queue);
65 } else if (ref is M.TokenStreamRef) { 66 } else if (ref is M.TokenStreamRef) {
66 return new TokenStreamRefElement(isolate, ref, queue: queue); 67 return new TokenStreamRefElement(isolate, ref, queue: queue);
67 } else if (ref is M.UnknownObjectRef) { 68 } else if (ref is M.UnknownObjectRef) {
68 return new UnknownObjectRefElement(isolate, ref, queue: queue); 69 return new UnknownObjectRefElement(isolate, ref, queue: queue);
70 } else {
71 return new AnchorElement(href: Uris.inspect(isolate, object: ref))
72 ..text = 'object';
69 } 73 }
70 } 74 }
71 return null; 75 throw new Exception('Unknown runtimeType (${ref.runtimeType})');
rmacnak 2016/09/01 22:24:51 Unknown ref
72 } 76 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698