Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: runtime/observatory/lib/src/elements/helpers/any_ref.dart

Issue 2303073002: Avoid to return null in anyRef if object is not known (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/helpers/any_ref.dart
diff --git a/runtime/observatory/lib/src/elements/helpers/any_ref.dart b/runtime/observatory/lib/src/elements/helpers/any_ref.dart
index 03c170c5aef1297c801fa51190d41852820edef2..d70733b04c3437e9ed8ac15c7faa7f345ed6ce02 100644
--- a/runtime/observatory/lib/src/elements/helpers/any_ref.dart
+++ b/runtime/observatory/lib/src/elements/helpers/any_ref.dart
@@ -11,6 +11,7 @@ import 'package:observatory/src/elements/error_ref.dart';
import 'package:observatory/src/elements/field_ref.dart';
import 'package:observatory/src/elements/function_ref.dart';
import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
+import 'package:observatory/src/elements/helpers/uris.dart';
import 'package:observatory/src/elements/icdata_ref.dart';
import 'package:observatory/src/elements/instance_ref.dart';
import 'package:observatory/src/elements/megamorphiccache_ref.dart';
@@ -66,7 +67,10 @@ Element anyRef(M.IsolateRef isolate, ref,
return new TokenStreamRefElement(isolate, ref, queue: queue);
} else if (ref is M.UnknownObjectRef) {
return new UnknownObjectRefElement(isolate, ref, queue: queue);
+ } else {
+ return new AnchorElement(href: Uris.inspect(isolate, object: ref))
+ ..text = 'object';
}
}
- return null;
+ throw new Exception('Unknown runtimeType (${ref.runtimeType})');
rmacnak 2016/09/01 22:24:51 Unknown ref
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698