Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2302773005: Fixes positioning of shadow layer (Closed)

Created:
4 years, 3 months ago by varkha
Modified:
4 years, 3 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, kalyank, sadrul, llandwerlin-old
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes positioning of shadow layer Noticed this while working on overview mode shadow. This case may not be exercised now but will be with the overview mode CL https://codereview.chromium.org/2239233002. Occlusion bounds were set incorrectly for the case when the shadow was set to be smaller than its parent layer such as when the parent layer has a transparent border and needs the shadow to be smaller. BUG=NONE Committed: https://crrev.com/110b973f801b8a8dbda0e9109f70ce6e71a13ac2 Cr-Commit-Position: refs/heads/master@{#416306}

Patch Set 1 : Fixes positioning of shadow layer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M ash/mus/shadow.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M ui/wm/core/shadow.cc View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
varkha
sadrul@, can you please take a look? This seems to be a typo-like mistake introduced ...
4 years, 3 months ago (2016-09-02 15:43:17 UTC) #2
sadrul
lgtm (I wonder if we could share more code between the two)
4 years, 3 months ago (2016-09-02 16:36:55 UTC) #6
varkha
+sky@ for OWNERS in ash/mus/shadow.cc
4 years, 3 months ago (2016-09-02 18:21:46 UTC) #10
sky
LGTM
4 years, 3 months ago (2016-09-02 18:31:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302773005/20001
4 years, 3 months ago (2016-09-02 18:37:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302773005/20001
4 years, 3 months ago (2016-09-02 18:38:49 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-02 18:42:51 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 18:46:09 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/110b973f801b8a8dbda0e9109f70ce6e71a13ac2
Cr-Commit-Position: refs/heads/master@{#416306}

Powered by Google App Engine
This is Rietveld 408576698