|
|
Chromium Code Reviews
DescriptionFixes positioning of shadow layer
Noticed this while working on overview mode shadow. This case may not be
exercised now but will be with the overview mode CL
https://codereview.chromium.org/2239233002.
Occlusion bounds were set incorrectly for the case when the shadow
was set to be smaller than its parent layer such as when the parent layer
has a transparent border and needs the shadow to be smaller.
BUG=NONE
Committed: https://crrev.com/110b973f801b8a8dbda0e9109f70ce6e71a13ac2
Cr-Commit-Position: refs/heads/master@{#416306}
Patch Set 1 : Fixes positioning of shadow layer #
Messages
Total messages: 21 (13 generated)
varkha@chromium.org changed reviewers: + sadrul@chromium.org
sadrul@, can you please take a look? This seems to be a typo-like mistake introduced in https://codereview.chromium.org/2083083004. Thanks!
Patchset #1 (id:1) has been deleted
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm (I wonder if we could share more code between the two)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
varkha@chromium.org changed reviewers: + sky@chromium.org
+sky@ for OWNERS in ash/mus/shadow.cc
LGTM
The CQ bit was checked by varkha@chromium.org
The CQ bit was unchecked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fixes positioning of shadow layer Noticed this while working on overview mode shadow. This case may not be exercised now but will be with the overview mode CL https://codereview.chromium.org/2239233002. Occlusion bounds were set incorrectly for the case when the shadow was set to be smaller than its parent layer such as when the parent layer has a transparent border and needs the shadow to be smaller. BUG=NONE ========== to ========== Fixes positioning of shadow layer Noticed this while working on overview mode shadow. This case may not be exercised now but will be with the overview mode CL https://codereview.chromium.org/2239233002. Occlusion bounds were set incorrectly for the case when the shadow was set to be smaller than its parent layer such as when the parent layer has a transparent border and needs the shadow to be smaller. BUG=NONE ==========
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fixes positioning of shadow layer Noticed this while working on overview mode shadow. This case may not be exercised now but will be with the overview mode CL https://codereview.chromium.org/2239233002. Occlusion bounds were set incorrectly for the case when the shadow was set to be smaller than its parent layer such as when the parent layer has a transparent border and needs the shadow to be smaller. BUG=NONE ========== to ========== Fixes positioning of shadow layer Noticed this while working on overview mode shadow. This case may not be exercised now but will be with the overview mode CL https://codereview.chromium.org/2239233002. Occlusion bounds were set incorrectly for the case when the shadow was set to be smaller than its parent layer such as when the parent layer has a transparent border and needs the shadow to be smaller. BUG=NONE ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fixes positioning of shadow layer Noticed this while working on overview mode shadow. This case may not be exercised now but will be with the overview mode CL https://codereview.chromium.org/2239233002. Occlusion bounds were set incorrectly for the case when the shadow was set to be smaller than its parent layer such as when the parent layer has a transparent border and needs the shadow to be smaller. BUG=NONE ========== to ========== Fixes positioning of shadow layer Noticed this while working on overview mode shadow. This case may not be exercised now but will be with the overview mode CL https://codereview.chromium.org/2239233002. Occlusion bounds were set incorrectly for the case when the shadow was set to be smaller than its parent layer such as when the parent layer has a transparent border and needs the shadow to be smaller. BUG=NONE Committed: https://crrev.com/110b973f801b8a8dbda0e9109f70ce6e71a13ac2 Cr-Commit-Position: refs/heads/master@{#416306} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/110b973f801b8a8dbda0e9109f70ce6e71a13ac2 Cr-Commit-Position: refs/heads/master@{#416306} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
