Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2302283002: Forking the type system between Crankshaft & Turbofan. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Forking the type system between Crankshaft & Turbofan. Our Type class has a semantic and representational dimension. Much code in src/ast, Crankshaft and Turbofan is based on it. Going forward in Turbofan we'd like to remove representational information entirely. To that end, new type AstType has been created to preserve existing behavior for the benefit of Crankshaft and the AST. BUG= Committed: https://crrev.com/17e9e2f4c853e48e0df84103e62cf59ed6684d1b Cr-Commit-Position: refs/heads/master@{#39135}

Patch Set 1 #

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1391 lines, -1420 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/asmjs/asm-typer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/ast.h View 9 chunks +11 lines, -11 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/ast-type-bounds.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + src/ast/ast-types.h View 1 21 chunks +324 lines, -287 lines 0 comments Download
A + src/ast/ast-types.cc View 47 chunks +224 lines, -235 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M src/crankshaft/hydrogen.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 24 chunks +67 lines, -75 lines 0 comments Download
M src/crankshaft/hydrogen-types.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-types.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M src/crankshaft/typing.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/crankshaft/typing.cc View 17 chunks +61 lines, -58 lines 0 comments Download
M src/effects.h View 3 chunks +12 lines, -12 lines 0 comments Download
M src/field-type.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/field-type.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/ic-state.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/ic-state.cc View 3 chunks +21 lines, -23 lines 0 comments Download
M src/parsing/parameter-initializer-rewriter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 2 chunks +6 lines, -11 lines 0 comments Download
M src/type-info.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M src/types.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/cctest/ast-types-fuzz.h View 8 chunks +122 lines, -116 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +1 line, -0 lines 0 comments Download
A + test/cctest/test-ast-types.cc View 100 chunks +459 lines, -494 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-types.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
mvstanton
Hi Benedikt, Here is the CL we discussed. It's rather large, but quite mechanical. --Mike
4 years, 3 months ago (2016-09-02 11:21:29 UTC) #2
Benedikt Meurer
LGTM, thanks.
4 years, 3 months ago (2016-09-02 11:49:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302283002/20001
4 years, 3 months ago (2016-09-02 12:35:12 UTC) #12
mvstanton
Hi Andreas, Could you have a look at the files src/asmjs/asm-typer.h, and src/parsing/parameter-initializer-rewriter.h for owner ...
4 years, 3 months ago (2016-09-02 12:44:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23197)
4 years, 3 months ago (2016-09-02 12:47:32 UTC) #17
rossberg
On 2016/09/02 12:47:32, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-02 12:48:55 UTC) #18
rossberg
On 2016/09/02 12:48:55, rossberg wrote: > On 2016/09/02 12:47:32, commit-bot: I haz the power wrote: ...
4 years, 3 months ago (2016-09-02 12:49:13 UTC) #19
rossberg
Oops... Aforementioned files LGTM
4 years, 3 months ago (2016-09-02 12:49:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302283002/20001
4 years, 3 months ago (2016-09-02 13:00:42 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 13:04:01 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 13:04:47 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17e9e2f4c853e48e0df84103e62cf59ed6684d1b
Cr-Commit-Position: refs/heads/master@{#39135}

Powered by Google App Engine
This is Rietveld 408576698