Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: src/ast/ast.h

Issue 2302283002: Forking the type system between Crankshaft & Turbofan. (Closed)
Patch Set: Nits. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/asmjs/asm-typer.h ('k') | src/ast/ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index f3e335bd571fd41763ff089a0cce9cbce8f757c4..cc6a64390c9dd12c70a6bab1a4e7e70b0b242e77 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -5,6 +5,7 @@
#ifndef V8_AST_AST_H_
#define V8_AST_AST_H_
+#include "src/ast/ast-types.h"
#include "src/ast/ast-value-factory.h"
#include "src/ast/modules.h"
#include "src/ast/variables.h"
@@ -17,7 +18,6 @@
#include "src/parsing/token.h"
#include "src/runtime/runtime.h"
#include "src/small-pointer-list.h"
-#include "src/types.h"
#include "src/utils.h"
namespace v8 {
@@ -939,8 +939,8 @@ class CaseClause final : public Expression {
BailoutId EntryId() const { return BailoutId(local_id(0)); }
TypeFeedbackId CompareId() { return TypeFeedbackId(local_id(1)); }
- Type* compare_type() { return compare_type_; }
- void set_compare_type(Type* type) { compare_type_ = type; }
+ AstType* compare_type() { return compare_type_; }
+ void set_compare_type(AstType* type) { compare_type_ = type; }
// CaseClause will have both a slot in the feedback vector and the
// TypeFeedbackId to record the type information. TypeFeedbackId is used by
@@ -962,7 +962,7 @@ class CaseClause final : public Expression {
Expression* label_;
Label body_target_;
ZoneList<Statement*>* statements_;
- Type* compare_type_;
+ AstType* compare_type_;
FeedbackVectorSlot type_feedback_slot_;
};
@@ -2135,14 +2135,14 @@ class CountOperation final : public Expression {
KeyedAccessStoreMode GetStoreMode() const {
return StoreModeField::decode(bit_field_);
}
- Type* type() const { return type_; }
+ AstType* type() const { return type_; }
void set_key_type(IcCheckType type) {
bit_field_ = KeyTypeField::update(bit_field_, type);
}
void set_store_mode(KeyedAccessStoreMode mode) {
bit_field_ = StoreModeField::update(bit_field_, mode);
}
- void set_type(Type* type) { type_ = type; }
+ void set_type(AstType* type) { type_ = type; }
static int num_ids() { return parent_num_ids() + 4; }
BailoutId AssignmentId() const { return BailoutId(local_id(0)); }
@@ -2187,7 +2187,7 @@ class CountOperation final : public Expression {
uint16_t bit_field_;
FeedbackVectorSlot slot_;
FeedbackVectorSlot binary_operation_slot_;
- Type* type_;
+ AstType* type_;
Expression* expression_;
SmallMapList receiver_types_;
};
@@ -2207,8 +2207,8 @@ class CompareOperation final : public Expression {
TypeFeedbackId CompareOperationFeedbackId() const {
return TypeFeedbackId(local_id(0));
}
- Type* combined_type() const { return combined_type_; }
- void set_combined_type(Type* type) { combined_type_ = type; }
+ AstType* combined_type() const { return combined_type_; }
+ void set_combined_type(AstType* type) { combined_type_ = type; }
// CompareOperation will have both a slot in the feedback vector and the
// TypeFeedbackId to record the type information. TypeFeedbackId is used
@@ -2234,7 +2234,7 @@ class CompareOperation final : public Expression {
op_(op),
left_(left),
right_(right),
- combined_type_(Type::None()) {
+ combined_type_(AstType::None()) {
DCHECK(Token::IsCompareOp(op));
}
@@ -2245,7 +2245,7 @@ class CompareOperation final : public Expression {
Expression* left_;
Expression* right_;
- Type* combined_type_;
+ AstType* combined_type_;
FeedbackVectorSlot type_feedback_slot_;
};
« no previous file with comments | « src/asmjs/asm-typer.h ('k') | src/ast/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698