Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2302113002: Address feedback from "MD Settings: fix infinite setInterval loop" (Closed)

Created:
4 years, 3 months ago by michaelpg
Modified:
4 years, 3 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address feedback from "MD Settings: fix infinite setInterval loop" BUG=643022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6029c61672d1a5d59cb7fbd5b5047b54b0ea48c5 Cr-Commit-Position: refs/heads/master@{#416089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/browser/resources/settings/settings_main/settings_main.html View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
michaelpg
Addressed comments from previous review.
4 years, 3 months ago (2016-09-01 20:57:15 UTC) #3
dschuyler
lgtm
4 years, 3 months ago (2016-09-01 21:00:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2302113002/1
4 years, 3 months ago (2016-09-01 21:14:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 22:36:30 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 22:38:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6029c61672d1a5d59cb7fbd5b5047b54b0ea48c5
Cr-Commit-Position: refs/heads/master@{#416089}

Powered by Google App Engine
This is Rietveld 408576698