Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2302113002: Address feedback from "MD Settings: fix infinite setInterval loop" (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index 7a53a64bac54c0e4129f34cdf29acddc88c260dc..4c0a877493bbef7ec04855652f57866dd5d9e42c 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -59,14 +59,8 @@ var MainPageBehaviorImpl = {
} else {
doWhenReady(
function() {
- if (this.scrollHeight > 0)
- return true;
-
- // Height is irrelevant if this page isn't the current page.
- if (!settings.Route[this.route].contains(settings.getCurrentRoute()))
- return true;
-
- return false;
+ return this.scrollHeight > 0 ||
+ !settings.Route[this.route].contains(settings.getCurrentRoute());
}.bind(this),
this.tryTransitionToSection_.bind(this));
}
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698