Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2302113002: Address feedback from "MD Settings: fix infinite setInterval loop" (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page/main_page_behavior.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/promise_resolver.html"> 3 <link rel="import" href="chrome://resources/html/promise_resolver.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
5 <link rel="import" href="/about_page/about_page.html"> 5 <link rel="import" href="/about_page/about_page.html">
6 <link rel="import" href="/advanced_page/advanced_page.html"> 6 <link rel="import" href="/advanced_page/advanced_page.html">
7 <link rel="import" href="/basic_page/basic_page.html"> 7 <link rel="import" href="/basic_page/basic_page.html">
8 <link rel="import" href="/route.html"> 8 <link rel="import" href="/route.html">
9 <link rel="import" href="/settings_page/main_page_behavior.html"> 9 <link rel="import" href="/settings_page/main_page_behavior.html">
10 <link rel="import" href="/settings_vars_css.html"> 10 <link rel="import" href="/settings_vars_css.html">
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 font-size: 120%; 51 font-size: 120%;
52 margin-bottom: 10px; 52 margin-bottom: 10px;
53 } 53 }
54 </style> 54 </style>
55 <content select="paper-icon-button"></content> 55 <content select="paper-icon-button"></content>
56 <div id="noSearchResults" hidden$="[[!showNoResultsFound_]]"> 56 <div id="noSearchResults" hidden$="[[!showNoResultsFound_]]">
57 <div>$i18n{searchNoResults}</div> 57 <div>$i18n{searchNoResults}</div>
58 <div>$i18nRaw{searchNoResultsHelp}</div> 58 <div>$i18nRaw{searchNoResultsHelp}</div>
59 </div> 59 </div>
60 <template is="dom-if" if="[[showPages_.basic]]"> 60 <template is="dom-if" if="[[showPages_.basic]]">
61 <settings-basic-page route="BASIC" 61 <settings-basic-page route="BASIC" prefs="{{prefs}}"
62 prefs="{{prefs}}"
63 page-visibility="[[pageVisibility]]" 62 page-visibility="[[pageVisibility]]"
64 on-subpage-expand="onSubpageExpand_"> 63 on-subpage-expand="onSubpageExpand_">
65 </settings-basic-page> 64 </settings-basic-page>
66 </template> 65 </template>
67 <template is="dom-if" 66 <template is="dom-if"
68 if="[[showAdvancedSettings_(pageVisibility.advancedSettings)]]"> 67 if="[[showAdvancedSettings_(pageVisibility.advancedSettings)]]">
69 <template is="dom-if" if="[[showAdvancedToggle_( 68 <template is="dom-if" if="[[showAdvancedToggle_(
70 showPages_.basic, hasExpandedSection_, previousShowPages_)]]"> 69 showPages_.basic, hasExpandedSection_, previousShowPages_)]]">
71 <div id="toggleSpacer"></div> 70 <div id="toggleSpacer"></div>
72 <div id="toggleContainer"> 71 <div id="toggleContainer">
73 <div id="advancedToggle" on-tap="toggleAdvancedPage_"> 72 <div id="advancedToggle" on-tap="toggleAdvancedPage_">
74 <span>$i18n{advancedPageTitle}</span> 73 <span>$i18n{advancedPageTitle}</span>
75 <iron-icon icon="[[arrowState_(showPages_.advanced)]]"></iron-icon> 74 <iron-icon icon="[[arrowState_(showPages_.advanced)]]"></iron-icon>
76 </div> 75 </div>
77 </div> 76 </div>
78 </template> 77 </template>
79 <template is="dom-if" if="[[showPages_.advanced]]"> 78 <template is="dom-if" if="[[showPages_.advanced]]">
80 <settings-advanced-page route="ADVANCED" 79 <settings-advanced-page route="ADVANCED" prefs="{{prefs}}"
81 prefs="{{prefs}}"
82 page-visibility="[[pageVisibility]]" 80 page-visibility="[[pageVisibility]]"
83 on-subpage-expand="onSubpageExpand_"> 81 on-subpage-expand="onSubpageExpand_">
84 </settings-advanced-page> 82 </settings-advanced-page>
85 </template> 83 </template>
86 </template> 84 </template>
87 <template is="dom-if" if="[[showPages_.about]]"> 85 <template is="dom-if" if="[[showPages_.about]]">
88 <settings-about-page route="ABOUT"></settings-about-page> 86 <settings-about-page route="ABOUT"></settings-about-page>
89 </template> 87 </template>
90 <div id="overscroll" style="padding-bottom: [[overscroll_]]px"></div> 88 <div id="overscroll" style="padding-bottom: [[overscroll_]]px"></div>
91 </template> 89 </template>
92 <script src="settings_main.js"></script> 90 <script src="settings_main.js"></script>
93 <script src="/search_settings.js"></script> 91 <script src="/search_settings.js"></script>
94 </dom-module> 92 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page/main_page_behavior.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698