Initial error handling code

src/core/SkOrderedReadBuffer.cpp

Index: src/core/SkOrderedReadBuffer.cpp
diff --git a/src/core/SkOrderedReadBuffer.cpp b/src/core/SkOrderedReadBuffer.cpp
index 9d991949084e5b9586d57baeaadf72363eb3e3ef..bab1626c491b31e77ad7098070f0d0861e3a6989 100644
--- a/src/core/SkOrderedReadBuffer.cpp
+++ b/src/core/SkOrderedReadBuffer.cpp
@@ -300,6 +300,11 @@ SkFlattenable* SkOrderedReadBuffer::readFlattenable() {
     if (factory) {
         uint32_t offset = fReader.offset();
         obj = (*factory)(*this);
+        if (fError != kNoError_SkError) {
+            delete obj;
+            obj = NULL;
+            fError = kNoError_SkError;

[reed1, 2013/08/21 15:49:24]

Hmmm, maybe this is correct (to reset fError to none) or maybe we shouldn't hide
the fact that we had a failure... ?

[sugoi1, 2013/08/21 16:52:36]

It's only reset here so that the next read operation (or factory function call)
will not fail on the previous read operation's error. I could also set it to
"NoError" just before calling the factory function.

[scroggo, 2013/08/21 23:56:00]

This seems to be basically the same, since SkOrderedReadBuffer is going to
continue calling readFlattenable.

+        }
         // check that we read the amount we expected
         uint32_t sizeRead = fReader.offset() - offset;
         if (sizeRecorded != sizeRead) {