Initial error handling code

src/core/SkImageFilter.cpp

Index: src/core/SkImageFilter.cpp
diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp
index 222a02999715b658862474098a2cf0216665ab57..7a8c6335a7276fd850a6c93843fcaf07bbe4ac7e 100644
--- a/src/core/SkImageFilter.cpp
+++ b/src/core/SkImageFilter.cpp
@@ -62,6 +62,11 @@ SkImageFilter::SkImageFilter(SkFlattenableReadBuffer& buffer)
         }
     }
     buffer.readIRect(&fCropRect);
+
+    if ((fCropRect.fLeft > fCropRect.fRight) ||
+        (fCropRect.fTop  > fCropRect.fBottom)) {
+        buffer.setError(kInvalidArgument_SkError);

[reed1, 2013/08/21 15:49:24]

Should we "reset" ourselves since we're signaling an error?

e.g. delete all of the sub-objects in fInputs and free that array?

[sugoi1, 2013/08/21 16:52:36]

I guess it depends if we intend to put error handling code everywhere or just at
the caller site. Is the caller the one to decide how to handle errors or is each
individual object responsible for that ?

+    }
 }
 
 void SkImageFilter::flatten(SkFlattenableWriteBuffer& buffer) const {