Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: src/effects/SkBlurImageFilter.cpp

Issue 23021015: Initial error handling code (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkOrderedReadBuffer.cpp ('K') | « src/core/SkOrderedReadBuffer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkBlurImageFilter.cpp
diff --git a/src/effects/SkBlurImageFilter.cpp b/src/effects/SkBlurImageFilter.cpp
index 4b2d3b88ffff8ae3ea7838bbd351b0226682419c..21ba3375bb6bfec8c751bc60b34e6b74a27a3753 100644
--- a/src/effects/SkBlurImageFilter.cpp
+++ b/src/effects/SkBlurImageFilter.cpp
@@ -19,6 +19,9 @@ SkBlurImageFilter::SkBlurImageFilter(SkFlattenableReadBuffer& buffer)
: INHERITED(buffer) {
fSigma.fWidth = buffer.readScalar();
fSigma.fHeight = buffer.readScalar();
+ if ((fSigma.fWidth < 0) || (fSigma.fHeight < 0)) {
+ buffer.setError(kInvalidArgument_SkError);
reed1 2013/08/21 15:49:24 should we set fSigma to (0,0) to be "safe" now tha
sugoi1 2013/08/21 16:52:36 I can do that, but it comes back to the original q
+ }
}
SkBlurImageFilter::SkBlurImageFilter(SkScalar sigmaX,
« src/core/SkOrderedReadBuffer.cpp ('K') | « src/core/SkOrderedReadBuffer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698