Issue 23021012: Fixing dart2js current script detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23021012: Fixing dart2js current script detection. (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing dart2js current script detection. The current script was being set on the Isolate after the new isolate was created, leaving the currentScript there unset. Any suggestions on tests that I can add or use to make sure this is correct? BUG=12635

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

Noticed that this was incorrect while debugging an unrelated IE10 issue.

7 years, 4 months ago (2013-08-16 19:35:32 UTC) #1

blois

On 2013/08/16 19:35:32, blois wrote: > Noticed that this was incorrect while debugging an unrelated ...

7 years, 4 months ago (2013-08-22 17:25:32 UTC) #2

ahe

7 years, 3 months ago (2013-08-27 17:26:18 UTC) #3

I think this CL can be subsumed by https://codereview.chromium.org/23523003/.

Expand Messages | Collapse Messages