Address a number of issues related to computation of currentScript and deferred loading.

Address a number of issues related to computation of currentScript and deferred loading.

* Store currentScript on init, as it is a cross-isolate shared value.

* Clean up deferred loading.

* Fix deferred loading tests so they inform the test runner about asynchronous operations.

BUG=http://dartbug.com/12635
BUG=http://dartbug.com/10622
BUG=http://dartbug.com/9158
R=blois@google.com, ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26903

[blois, 2013-08-27 23:23:13]

changes lgtm

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/as...
File dart/sdk/lib/_internal/lib/async_patch.dart (right):

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/as...
dart/sdk/lib/_internal/lib/async_patch.dart:55: JS('void', '(new
Function(#))()', 'loadRelativeToScript("$uri")');
Where is loadRelativeToScript defined?

[ahe, 2013-08-28 05:33:54]

Thanks Pete!

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/as...
File dart/sdk/lib/_internal/lib/async_patch.dart (right):

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/as...
dart/sdk/lib/_internal/lib/async_patch.dart:55: JS('void', '(new
Function(#))()', 'loadRelativeToScript("$uri")');
On 2013/08/27 23:23:13, blois wrote:
> Where is loadRelativeToScript defined?

https://hg.mozilla.org/mozilla-central/file/ca06d27f049f/js/src/shell/js.cpp#...

I found it by running the following in jsshell:

function dump(x) { for (var p in x) {print(x)}}
dump(this);

I think you might be able to get the documentation in jsshell by typing
'help("loadRelativeToScript")'

[ngeoffray, 2013-08-28 06:36:17]

LGTM

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/is...
File dart/sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/is...
dart/sdk/lib/_internal/lib/isolate_helper.dart:430: ' && typeof os == "object"
&& "system" in os');
Where did you find this? Maybe also check isJsshell and throw if that's also
true?

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/is...
dart/sdk/lib/_internal/lib/isolate_helper.dart:435: 'typeof version ==
"function" && typeof system == "function"');
Ditto.

[ahe, 2013-08-28 06:54:01]

Thanks Nicolas. I like your suggestion, but I implemented it differently.

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/is...
File dart/sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/23523003/diff/1/dart/sdk/lib/_internal/lib/is...
dart/sdk/lib/_internal/lib/isolate_helper.dart:430: ' && typeof os == "object"
&& "system" in os');
On 2013/08/28 06:36:17, ngeoffray wrote:
> Where did you find this?

I looked at the properties of the global object in d8 vs jsshell.

> Maybe also check isJsshell and throw if that's also
> true?

Since this code would be included in generated output, I'd rather test it using
a dart2js_native test.

[ahe, 2013-08-30 06:57:51]

Committed patchset #2 manually as r26903 (presubmit successful).