Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2301883002: CallInterfaceDescriptor should use MachineType (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CallInterfaceDescriptor should use MachineType. We really just need representation information from the CallInterfaceDescriptor. This change allows us to keep that, get away from Type, and it's Zone-based allocation as well. BUG= Committed: https://crrev.com/d27f7f7ceba78b627506382d02b88121a3e9b9d7 Cr-Commit-Position: refs/heads/master@{#39105}

Patch Set 1 #

Patch Set 2 : Removed FunctionType usage completely. #

Patch Set 3 : Remove unneeded zone in the isolate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -463 lines) Patch
M src/code-stubs.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 3 chunks +2 lines, -34 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/interface-descriptors.h View 1 2 7 chunks +40 lines, -43 lines 0 comments Download
M src/interface-descriptors.cc View 1 13 chunks +256 lines, -377 lines 0 comments Download
M src/isolate.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mvstanton
Hi Benedikt, Here is the CL we discussed. Thanks for the look! --Mike
4 years, 3 months ago (2016-09-01 16:40:36 UTC) #6
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-01 18:43:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2301883002/60001
4 years, 3 months ago (2016-09-01 19:08:33 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-01 20:08:46 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:09:52 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d27f7f7ceba78b627506382d02b88121a3e9b9d7
Cr-Commit-Position: refs/heads/master@{#39105}

Powered by Google App Engine
This is Rietveld 408576698