Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: src/compiler/linkage.cc

Issue 2301883002: CallInterfaceDescriptor should use MachineType (Closed)
Patch Set: Remove unneeded zone in the isolate. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/linkage.cc
diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc
index 82c2b1b6c162dabc6677c2101c0d95d416f34ed3..cb84516ea28a665d9de9122ee0f58c0992c7e972 100644
--- a/src/compiler/linkage.cc
+++ b/src/compiler/linkage.cc
@@ -24,36 +24,6 @@ LinkageLocation regloc(Register reg, MachineType type) {
return LinkageLocation::ForRegister(reg.code(), type);
}
-MachineType reptyp(Representation representation) {
- switch (representation.kind()) {
- case Representation::kInteger8:
- return MachineType::Int8();
- case Representation::kUInteger8:
- return MachineType::Uint8();
- case Representation::kInteger16:
- return MachineType::Int16();
- case Representation::kUInteger16:
- return MachineType::Uint16();
- case Representation::kInteger32:
- return MachineType::Int32();
- case Representation::kSmi:
- return MachineType::TaggedSigned();
- case Representation::kTagged:
- return MachineType::AnyTagged();
- case Representation::kHeapObject:
- return MachineType::TaggedPointer();
- case Representation::kDouble:
- return MachineType::Float64();
- case Representation::kExternal:
- return MachineType::Pointer();
- case Representation::kNone:
- case Representation::kNumRepresentations:
- break;
- }
- UNREACHABLE();
- return MachineType::None();
-}
-
} // namespace
@@ -382,8 +352,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
if (i < register_parameter_count) {
// The first parameters go in registers.
Register reg = descriptor.GetRegisterParameter(i);
- MachineType type =
- reptyp(RepresentationFromType(descriptor.GetParameterType(i)));
+ MachineType type = descriptor.GetParameterType(i);
locations.AddParam(regloc(reg, type));
} else {
// The rest of the parameters go on the stack.
@@ -452,8 +421,7 @@ CallDescriptor* Linkage::GetBytecodeDispatchCallDescriptor(
if (i < register_parameter_count) {
// The first parameters go in registers.
Register reg = descriptor.GetRegisterParameter(i);
- MachineType type =
- reptyp(RepresentationFromType(descriptor.GetParameterType(i)));
+ MachineType type = descriptor.GetParameterType(i);
locations.AddParam(regloc(reg, type));
} else {
// The rest of the parameters go on the stack.
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698