Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/crankshaft/hydrogen-instructions.h

Issue 2301883002: CallInterfaceDescriptor should use MachineType (Closed)
Patch Set: Remove unneeded zone in the isolate. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/linkage.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <iosfwd> 9 #include <iosfwd>
10 10
(...skipping 2157 matching lines...) Expand 10 before | Expand all | Expand 10 after
2168 int OperandCount() const final { return values_.length(); } 2168 int OperandCount() const final { return values_.length(); }
2169 HValue* OperandAt(int index) const final { return values_[index]; } 2169 HValue* OperandAt(int index) const final { return values_[index]; }
2170 2170
2171 Representation RequiredInputRepresentation(int index) final { 2171 Representation RequiredInputRepresentation(int index) final {
2172 if (index == 0 || index == 1) { 2172 if (index == 0 || index == 1) {
2173 // Target + context 2173 // Target + context
2174 return Representation::Tagged(); 2174 return Representation::Tagged();
2175 } else { 2175 } else {
2176 int par_index = index - 2; 2176 int par_index = index - 2;
2177 DCHECK(par_index < GetParameterCount()); 2177 DCHECK(par_index < GetParameterCount());
2178 return RepresentationFromType(descriptor_.GetParameterType(par_index)); 2178 return RepresentationFromMachineType(
2179 descriptor_.GetParameterType(par_index));
2179 } 2180 }
2180 } 2181 }
2181 2182
2182 DECLARE_CONCRETE_INSTRUCTION(CallWithDescriptor) 2183 DECLARE_CONCRETE_INSTRUCTION(CallWithDescriptor)
2183 2184
2184 // Defines whether this instruction corresponds to a JS call at tail position. 2185 // Defines whether this instruction corresponds to a JS call at tail position.
2185 TailCallMode syntactic_tail_call_mode() const { 2186 TailCallMode syntactic_tail_call_mode() const {
2186 return SyntacticTailCallModeField::decode(bit_field_); 2187 return SyntacticTailCallModeField::decode(bit_field_);
2187 } 2188 }
2188 2189
(...skipping 4937 matching lines...) Expand 10 before | Expand all | Expand 10 after
7126 bool IsDeletable() const override { return true; } 7127 bool IsDeletable() const override { return true; }
7127 }; 7128 };
7128 7129
7129 #undef DECLARE_INSTRUCTION 7130 #undef DECLARE_INSTRUCTION
7130 #undef DECLARE_CONCRETE_INSTRUCTION 7131 #undef DECLARE_CONCRETE_INSTRUCTION
7131 7132
7132 } // namespace internal 7133 } // namespace internal
7133 } // namespace v8 7134 } // namespace v8
7134 7135
7135 #endif // V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_ 7136 #endif // V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/compiler/linkage.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698