[Command Buffer] We may need to adjust texture format when clear texture level by tex{Sub}Image

[Command Buffer] We may need to adjust texture format when clear texture level by tex{Sub}Image.
Because some color formats in GLES, say LUMINANCE/ALPHA, can not be supported by desktop OGL directly.

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1687500b6fd9c005536a030e6a0801d67c8fb188
Cr-Commit-Position: refs/heads/master@{#416388}

[yunchao, 2016-09-01 09:33:54]

Description was changed from

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image

BUG=
==========

to

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-09-01 10:21:27]

Description was changed from

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-09-01 10:21:27]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, piman@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2016-09-01 10:23:21]

Pending on this change: https://codereview.chromium.org/2293853003/

PTAL. Thanks.

[yunchao, 2016-09-01 10:25:57]

On 2016/09/01 10:23:21, yunchao wrote:
> Pending on this change: https://codereview.chromium.org/2293853003/
> 
> PTAL. Thanks.

Once that patch is landed. I will update the webgl2 conformance test
expectation, and test this change on Chromium bots.

[Zhenyao Mo, 2016-09-01 17:27:16]

On 2016/09/01 10:25:57, yunchao wrote:
> On 2016/09/01 10:23:21, yunchao wrote:
> > Pending on this change: https://codereview.chromium.org/2293853003/
> > 
> > PTAL. Thanks.
> 
> Once that patch is landed. I will update the webgl2 conformance test
> expectation, and test this change on Chromium bots.

Thanks for tracking this down. LGTM.

[yunchao, 2016-09-01 17:32:16]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-09-01 17:48:24]

Description was changed from

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image. 
Because some color formats in GLES, say LUMINANCE/ALPHA, can not be supported by
desktop OGL directly.  

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-09-01 17:55:17]

Thanks for finding this. I should have been more careful with
https://codereview.chromium.org/2236123002/ and found more places it was needed.
LGTM

[commit-bot: I haz the power, 2016-09-01 17:57:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:57:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[yunchao, 2016-09-01 18:02:37]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 18:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 18:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:13:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[yunchao, 2016-09-01 23:20:07]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[yunchao, 2016-09-01 23:20:12]

The CQ bit was unchecked by yunchao.he@intel.com

[yunchao, 2016-09-01 23:20:19]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:20:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 23:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 23:52:26]

Dry run: Exceeded global retry quota

[yunchao, 2016-09-02 07:17:02]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 07:17:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 09:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 09:09:34]

Dry run: Exceeded global retry quota

[yunchao, 2016-09-02 09:17:14]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 09:17:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 10:51:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 10:51:27]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-09-02 13:42:57]

This change can fix the luminance/alpha failure on MacOSX, but it still failed
on Windows. In addition, The latest patchset have some changes to fix failures
introduced in gpu_unittests. So, Zhenyao and Ken, could you take another look?

[yunchao, 2016-09-02 13:44:19]

On 2016/09/02 13:42:57, yunchao wrote:
> This change can fix the luminance/alpha failure on MacOSX, but it still failed
> on Windows. In addition, The latest patchset have some changes to fix failures
> introduced in gpu_unittests. So, Zhenyao and Ken, could you take another look?

We will take a look at the failures of copy-texture-image-luma-format.html in
Windows later.

[Zhenyao Mo, 2016-09-02 17:05:56]

lgtm again

[yunchao, 2016-09-02 23:26:18]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 23:27:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 23:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 23:32:40]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-09-02 23:33:30]

The CQ bit was checked by yunchao.he@intel.com

[yunchao, 2016-09-02 23:33:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2301823003/#ps60001
(title: "copy-texture-image-luma-format.html still fails on Win")

[commit-bot: I haz the power, 2016-09-02 23:34:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 23:39:03]

Description was changed from

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image. 
Because some color formats in GLES, say LUMINANCE/ALPHA, can not be supported by
desktop OGL directly.  

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image. 
Because some color formats in GLES, say LUMINANCE/ALPHA, can not be supported by
desktop OGL directly.  

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-02 23:39:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 23:40:51]

Description was changed from

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image. 
Because some color formats in GLES, say LUMINANCE/ALPHA, can not be supported by
desktop OGL directly.  

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command Buffer] We may need to adjust texture format when clear texture level
by tex{Sub}Image.
Because some color formats in GLES, say LUMINANCE/ALPHA, can not be supported by
desktop OGL directly.

BUG=643121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/1687500b6fd9c005536a030e6a0801d67c8fb188
Cr-Commit-Position: refs/heads/master@{#416388}
==========

[commit-bot: I haz the power, 2016-09-02 23:40:53]

Patchset 4 (id:??) landed as
https://crrev.com/1687500b6fd9c005536a030e6a0801d67c8fb188
Cr-Commit-Position: refs/heads/master@{#416388}