Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: gpu/command_buffer/service/framebuffer_manager_unittest.cc

Issue 2301823003: [Command Buffer] We may need to adjust texture format when clear texture level by tex{Sub}Image (Closed)
Patch Set: copy-texture-image-luma-format.html still fails in Windows Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/framebuffer_manager_unittest.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager_unittest.cc b/gpu/command_buffer/service/framebuffer_manager_unittest.cc
index cae851774921598e9ff094244556bc2b6d402338..3970f600b3e1fae1ed690be9583d47354d596fe7 100644
--- a/gpu/command_buffer/service/framebuffer_manager_unittest.cc
+++ b/gpu/command_buffer/service/framebuffer_manager_unittest.cc
@@ -759,6 +759,8 @@ TEST_F(FramebufferInfoTest, ClearPartiallyClearedAttachments) {
EXPECT_TRUE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
EXPECT_TRUE(framebuffer_->HasUnclearedColorAttachments());
// Clear it but nothing happens.
+ EXPECT_CALL(*decoder_.get(), GetFeatureInfo())
+ .WillRepeatedly(Return(feature_info_.get()));
framebuffer_->ClearUnclearedIntOr3DTexturesOrPartiallyClearedTextures(
decoder_.get(), texture_manager_.get());
EXPECT_FALSE(attachment->cleared());
@@ -848,6 +850,8 @@ TEST_F(FramebufferInfoTest, Clear3DTextureAttachments) {
EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
EXPECT_FALSE(framebuffer_->HasUnclearedColorAttachments());
// Clear it but nothing happens.
+ EXPECT_CALL(*decoder_.get(), GetFeatureInfo())
+ .WillRepeatedly(Return(feature_info_.get()));
framebuffer_->ClearUnclearedIntOr3DTexturesOrPartiallyClearedTextures(
decoder_.get(), texture_manager_.get());
EXPECT_TRUE(attachment->cleared());
@@ -924,6 +928,8 @@ TEST_F(FramebufferInfoTest, Clear3DOutsideRenderableRange) {
GL_UNSIGNED_BYTE, _, _, _))
.WillOnce(Return(true))
.RetiresOnSaturation();
+ EXPECT_CALL(*decoder_.get(), GetFeatureInfo())
+ .WillRepeatedly(Return(feature_info_.get()));
framebuffer_->ClearUnclearedIntOr3DTexturesOrPartiallyClearedTextures(
decoder_.get(), texture_manager_.get());
EXPECT_TRUE(attachment->cleared());
@@ -961,6 +967,8 @@ TEST_F(FramebufferInfoTest, ClearIntegerTextureAttachments) {
EXPECT_FALSE(framebuffer_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
EXPECT_FALSE(framebuffer_->HasUnclearedColorAttachments());
// Clear it but nothing happens.
+ EXPECT_CALL(*decoder_.get(), GetFeatureInfo())
+ .WillRepeatedly(Return(feature_info_.get()));
framebuffer_->ClearUnclearedIntOr3DTexturesOrPartiallyClearedTextures(
decoder_.get(), texture_manager_.get());
EXPECT_TRUE(attachment->cleared());
@@ -1043,6 +1051,8 @@ TEST_F(FramebufferInfoTest, ClearIntegerOutsideRenderableRange) {
GL_UNSIGNED_BYTE, _, _, _, _))
.WillOnce(Return(true))
.RetiresOnSaturation();
+ EXPECT_CALL(*decoder_.get(), GetFeatureInfo())
+ .WillRepeatedly(Return(feature_info_.get()));
framebuffer_->ClearUnclearedIntOr3DTexturesOrPartiallyClearedTextures(
decoder_.get(), texture_manager_.get());
EXPECT_TRUE(attachment->cleared());
« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | gpu/command_buffer/service/texture_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698